Fs/error on dob

[sertlab]

This PR fixes this issue
#26700

How to test

• Set DOB as a required during customer registration and try to register

Actual Result
Registration fails with message (under the calendar) "Please select a valid date"

Expected Result
Registration should be complete

What changed
preg_replace() modified in order moment js to accept the date format value
as it seems moment(date,'M/d/Y').isValid() returns false
but now moment(date,'M/dd/Y').isValid() returns true

[m2-assistant]

Hi @sertlab. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[mrtuvn]

@sertlab Can you cover your change with unit test ?
The last change of file Timezone in this PR
#26701

[sertlab]

@sertlab Can you cover your change with unit test ?
The last change of file Timezone in this PR
#26701

some unit test coverage added to this .

[ghost]

@sertlab unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

[mrtuvn]

@sertlab Can you run test case for class
lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php
Add some case to scopeDateDataProvider in this class
https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/Stdlib/Test/Unit/DateTime/TimezoneTest.php#L311

[bubasuma]

Hi @sertlab
Although replacing M/d/Y by M/dd/Y works for moment().isValid(). This is not really the moment JS equivalent of M/d/Y. See https://momentjs.com/docs/#/displaying/
I did some basic test with momentJS date formatting. See screenshot below

I believe the momentJS equivalent of M/d/Y should be M/D/Y. See screenshot below

[bubasuma]

Hi @sertlab
Thank you for your contribution and collaboration!
Internal Magento team is working on this issue right now.

[bubasuma]

Hi @sertlab
Thank you for your contribution and collaboration!
The issue was fixed by Magento team.
The fix will be available with the upcoming 2.4.0 release.

[m2-assistant]

Hi @sertlab, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.