24938: Fix wrong shipping amount in totals for multiple address is used.

[pradeep-wagento]

Description (*)

Fix wrong shipping amount in totals when multiple address is selected with different shipping amount.

Related Pull Requests

250180b

Fixed Issues (if relevant)

1. Multishipping checkout, shipping amount is not applied correctly when different on different addresses/items #23631: Multishipping checkout, shipping amount is not applied correctly when different on different addresses/items
2. Wrong shipping amount calculation when checkout with multiple address is used. #24938: Wrong shipping amount calculation when checkout with multiple address is used.

Manual testing scenarios (*)

Questions or comments

The commit shared in Related pull request doesn't seems to be as per magento standard. But any how it was merged. Remove those commit, which will be reproduce issue.
Apply the changes for this PR, issue will work and will be as per standard.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @pradeep-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[rogyar]

Hi @pradeep-wagento. Thank you for your collaboration. For improving the overall code quality, could I kindly ask you to fix the following static check failures (even if they are not related to your changes directly).

Also, according to the Definition of Done all changes in a PR should be covered by automated tests. I would suggest extending the following unit test.

Thank you!

[engcom-Charlie]

Hi, @pradeep-wagento linked issues aren't reproducible on 2.4-develop. Please check this and provide the correct steps to reproduce on the latest version.

[pradeep-wagento]

@engcom-Charlie

250180b doesn't seems to be as per magento standard. But any how it was merged. Remove this commit, which will be reproduce issue.
Apply the changes for this PR, issue will work and will be as per standard.

[sidolov]

Hi @pradeep-wagento , I'm closing the PR since the issue is not reproducing on the 2.4-develop branch. Feel free to reopen PR in case you find additional scenario.

[m2-assistant]

Hi @pradeep-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.