-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ZF2 components to Laminas components #26436
Migrate ZF2 components to Laminas components #26436
Conversation
Hi @ihor-sviziev. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@magento give me test instance |
Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you |
Hi @ihor-sviziev, here is your new Magento instance. |
babebbc
to
2d85fb6
Compare
2d85fb6
to
ec609e3
Compare
@magento run all tests |
@ihor-sviziev, Most of failures are because of "absence" of |
Current status is following:
From my perspective it’s better to do 1st option as it should not break custom extensions, hovered it should break even b2b and EE versions, but it is due to test failures /CC @Den4ik @lenaorobei @slavvka @fascinosum @lenaorobei once you will have decision, let me know if you need something from my side - I’ll update PR @fascinosum @lenaorobei is there any updates since that time, maybe you already decided on solution? |
Hi @ihor-sviziev, |
@lenaorobei thx for update! |
Guys what is the status of this? |
@diazwatson |
I was about to open an issue to look at this today and then I realised you were already working on this. |
hello @ihor-sviziev, @diazwatson |
Hi @ihor-sviziev, thank you for your contribution! |
Just leaving it here for the history.
So, if you also face this one, try to upgrade the composer version using |
Thanks for sharing it @eduard13 |
Description (*)
This PR do following:
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)