-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#18012: added i18n wrapper to be used in underscore templates for translation #26435
#18012: added i18n wrapper to be used in underscore templates for translation #26435
Conversation
Hi @sergiy-v. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@sergiy-v unfortunately, only members of the maintainers team are allowed to assign developers to the pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sergiy-v well done, thank you!
We just need to make sure the translation phrase is properly parsed and included in js-translation.json
dictionary file. Could you please check it?
References:
@dmytro-ch I'll check and add needed changes, thank you. |
Hi @dmytro-ch, thank you for the review. |
✔️ QA Passed |
…lates for translation #26435
Hi @sergiy-v, thank you for your contribution! |
Description
Introduced
i18n
method for underscore to provide an ability use translation in underscore templates.<%= _.i18n('Hello') %>
Fixed Issues
Manual testing scenarios
See #18012 for the example.
Contribution checklist