Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#18012: added i18n wrapper to be used in underscore templates for translation #26435

Conversation

sergiy-v
Copy link
Contributor

Description

Introduced i18n method for underscore to provide an ability use translation in underscore templates.
<%= _.i18n('Hello') %>

Fixed Issues

  1. Can not add string to underscore template using knockout #18012

Manual testing scenarios

See #18012 for the example.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@sergiy-v sergiy-v requested a review from dmytro-ch January 17, 2020 12:39
@sergiy-v sergiy-v requested a review from DrewML as a code owner January 17, 2020 12:39
@ghost ghost unassigned dmytro-ch Jan 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 17, 2020

Hi @sergiy-v. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@ghost
Copy link

ghost commented Jan 17, 2020

@sergiy-v unfortunately, only members of the maintainers team are allowed to assign developers to the pull request

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 17, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 17, 2020
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergiy-v well done, thank you!
We just need to make sure the translation phrase is properly parsed and included in js-translation.json dictionary file. Could you please check it?

References:

@sergiy-v
Copy link
Contributor Author

@sergiy-v well done, thank you!
We just need to make sure the translation phrase is properly parsed and included in js-translation.json dictionary file. Could you please check it?

References:

@dmytro-ch I'll check and add needed changes, thank you.

@sergiy-v sergiy-v requested a review from melnikovi as a code owner January 20, 2020 07:35
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6708 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 7, 2020

Hi @sergiy-v, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants