Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to Compare link does not show in mobile view under 640px in blank theme #26424

Merged

Conversation

ptylek
Copy link
Contributor

@ptylek ptylek commented Jan 16, 2020

Description (*)

Fix #26364: Add to Compare link not showing in mobile view under 640px for blank theme because the other PR only covered Luma.

Fixed Issues (if relevant)

  1. Add to Compare link not showing in mobile view under 640px #26364: Add to Compare link not showing in mobile view under 640px

Manual testing scenarios (*)

  1. Open Magento Product Page with Blank theme on mobile device
  2. Check if Add to Compare link is visible

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 16, 2020

Hi @ptylek. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6628 has been created to process this Pull Request
✳️ @krzksz, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jan 17, 2020
@engcom-Golf engcom-Golf self-assigned this Jan 17, 2020
@VladimirZaets VladimirZaets self-assigned this Jan 17, 2020
magento-engcom-team pushed a commit that referenced this pull request Jan 28, 2020
@magento-engcom-team magento-engcom-team merged commit 9ec1d67 into magento:2.4-develop Jan 28, 2020
@m2-assistant
Copy link

m2-assistant bot commented Jan 28, 2020

Hi @ptylek, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to Compare link not showing in mobile view under 640px
6 participants