MFTF: Replace invalid ActionGroup for AdminLogin

[lbajsarowicz]

Description (*)

The ActionGroup for logging in as admin was declared in module-cms-staging that is completely ridiculous. I moved that as a legacy one to backend module, as we already have 3 action groups for such behavior 🤦‍♂️ After merging all related Pull Requests, that Action Group can be removed.

Fixed Issues (if relevant)

1. https://github.com/magento/partners-magento2ee/pull/113
2. [ MFTF ] Mess in ActionGroups: invalid names, multiple nodes. #26331

Questions or comments

Had to extract the changes per-module. The previous try failed, because of conflicts.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @lbajsarowicz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[dmytro-ch]

Hi @lbajsarowicz, unfortunately, I could not find the original action group in 2.4-develop branch.
https://github.com/magento/magento2/tree/2.4-develop/app/code/Magento/Cms/Test/Mftf/ActionGroup
Have you already removed this action in the scope of another PR?

[lbajsarowicz]

CMS Staging module
Take a look into linked issue https://github.com/magento/partners-magento2ee/pull/113

-- Especially: https://github.com/magento/partners-magento2ee/pull/113/files#diff-1dc91bcc26d07540dece9d2a9931e2feL108

[dmytro-ch]

These action groups still have different names: LoginAsAnyUserActionGroup and LoginAsAnyUser.
Shouldn't we name it LoginAsAnyUser instead of LoginAsAnyUserActionGroup in this case?
Sorry for asking many questions, I just want to make sure I got the idea correctly. :)

[lbajsarowicz]

You are right. Thank you!

[magento-engcom-team]

Hi @dmytro-ch, thank you for the review.
ENGCOM-6594 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[lenaorobei]

Why would you mark it as deprecated instead of removing it?

[lbajsarowicz]

✔️ Lucky PR

[magento-engcom-team]

Hi @lenaorobei, thank you for the review.
ENGCOM-6594 has been created to process this Pull Request

[engcom-Alfa]

QA not applicable

[engcom-Golf]

Hi @lbajsarowicz could you please resolve conflicts ?

[lbajsarowicz]

@magento run Functional Tests CE
Flaky test

[m2-assistant]

Hi @lbajsarowicz, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.