Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#26245: Magento does not send an email about a refunded grouped product #26246

Merged
merged 4 commits into from
Feb 13, 2020
Merged

magento/magento2#26245: Magento does not send an email about a refunded grouped product #26246

merged 4 commits into from
Feb 13, 2020

Conversation

atwixfirster
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Magento does not send an email about a refunded grouped product #26245: Magento does not send an email about a refunded grouped product

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Thank you!

@atwixfirster atwixfirster requested a review from akaplya as a code owner January 3, 2020 00:09
@m2-assistant
Copy link

m2-assistant bot commented Jan 3, 2020

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Jan 3, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 3, 2020
dmytro-ch
dmytro-ch requested changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ch dmytro-ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @atwixfirster, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by automated tests?
Thank you!

@dmytro-ch dmytro-ch added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Progress: needs update labels Jan 8, 2020
@atwixfirster
Copy link
Contributor Author

Hello @atwixfirster, thank you for your contribution. Due to Magento Definition of Done the changes should be covered by tests. Could you please cover your fix by automated tests?
Thank you!

@dmytro-ch , can we deliver this fix without tests?

Thank you!

@engcom-Echo
Copy link
Contributor

@magento run all tests

@engcom-Echo engcom-Echo self-assigned this Jan 30, 2020
@engcom-Echo
Copy link
Contributor

I will take care of test coverage.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6768 has been created to process this Pull Request

@engcom-Bravo engcom-Bravo self-assigned this Jan 30, 2020
@engcom-Bravo
Copy link
Contributor

✔️ QA Passed

The Credit Memo is created and the e-mail is received

created_credit_memo
credmemo_email

@engcom-Echo engcom-Echo added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Jan 31, 2020
@engcom-Echo engcom-Echo requested a review from dmytro-ch January 31, 2020 09:31
@engcom-Echo
Copy link
Contributor

Failure of functional test, not related to the changes in this PR , test failing on 2.4-develop branch
image

@slavvka
Copy link
Member

slavvka commented Feb 10, 2020

MCHI is approved since there was introduced a protected method in class whose parent has the same protected method

@magento-engcom-team magento-engcom-team mentioned this pull request Feb 13, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2020
@slavvka
ENGCOM-6768: #26245: Magento does not send an email about a refunded …
1bc2445 
…grouped product #26246
magento-engcom-team pushed a commit that referenced this pull request Feb 13, 2020
@VladimirZaets
ENGCOM-6768: #26245: Magento does not send an email about a refunded …
a01f51a 
…grouped product #26246
@magento-engcom-team magento-engcom-team merged commit dfc44a1 into magento:2.4-develop Feb 13, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@cyildirim cyildirim mentioned this pull request Feb 1, 2021
Closed
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akaplya akaplya Awaiting requested review from akaplya

@dmytro-ch dmytro-ch Awaiting requested review from dmytro-ch

Assignees

@dmytro-ch dmytro-ch

@engcom-Bravo engcom-Bravo

@engcom-Echo engcom-Echo

Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: test coverage Component: GroupedProduct Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@atwixfirster @engcom-Echo @magento-engcom-team @engcom-Bravo @slavvka @dmytro-ch