Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Align some space between input and update button Minicart] #26234

Conversation

hitesh-wagento
Copy link
Contributor

Description (*)

Fixed some space between input and update button Minicart

Fixed Issues (if relevant)

  1. Need some space between input and update button Minicart #26227: Need some space between input and update button Minicart

Manual testing scenarios (*)

  1. Add any product in cart
  2. Click on input in Minicart
  3. Add Qty you will see the update button

Expected result

  1. Need some space between input and update button in Minicart like in mobile view.
    expected

Actual result

  1. No space between input and update button in Minicart
    actual

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jan 2, 2020

Hi @hitesh-wagento. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner labels Jan 2, 2020
@dmytro-ch dmytro-ch self-assigned this Jan 2, 2020
@dmytro-ch dmytro-ch added Cleanup Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests labels Jan 2, 2020
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6532 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@ghost ghost assigned ptylek Jan 8, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6532 has been created to process this Pull Request

@m2-assistant
Copy link

m2-assistant bot commented Jan 8, 2020

Hi @hitesh-wagento, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hitesh-wagento hitesh-wagento deleted the fixed-spacing-issue-minicartbutton-hitesh branch January 17, 2020 10:09
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Cleanup Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants