-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes phpcs errors and warnings for Magento\Framework\View\Element #26037
Fixes phpcs errors and warnings for Magento\Framework\View\Element #26037
Conversation
I was working with those classes and spotted a few warnings and errors that prevent from smooth pull requests. Here are most fixes.
Hi @krisdante. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
@krisdante Fix the static tests, then PR will be automatically approved. |
Hi @lbajsarowicz, thank you for the review.
|
✔️ QA Passed |
Hi @krisdante, thank you for your contribution! |
Description (*)
I was working with those classes and spotted a few warnings and errors
that prevent from smooth pull requests. Here are most fixes.
UiComponents and Messages are not processed. There are many, many changes, also in logic required.
Manual testing scenarios (*)
vendor/bin/phpcs --standard=dev/tests/static/framework/Magento/ruleset.xml lib/internal/Magento/Framework/View/Element/
Contribution checklist (*)