Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue 25930 #26011

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

divyajyothi5321
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Integration Success Message Text Overflow Issue in Admin #25930: Integration Success Message Text Overflow Issue in Admin

Manual testing scenarios (*)

  1. Go to admin->System->Extenstions->Integrations
  2. Add new integration name with 255 characters and save the integration
  3. Now the text overflow issue is fixed as shown in below screencast.

integrations

  1. When we delete, edit and duplicate the integration name we can also find this text overflow issue. By this fix we can resolve all these issues.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 12, 2019

Hi @divyajyothi5321. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @ptylek, thank you for the review.
ENGCOM-6458 has been created to process this Pull Request
✳️ @ptylek, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ptylek ptylek added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Dec 12, 2019
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Dec 13, 2019

Hello @divyajyothi5321
I am not able to reproduce this issue on the Magento 2.4-develop.

Testing scenario:

  1. Go to admin->System->Extenstions->Integrations
  2. Add new integration name with 255 characters and save the integration

Result:
Success message is not disturbing the page
image

@magento-engcom-team
Copy link
Contributor

Hi @krzksz, thank you for the review.
ENGCOM-6458 has been created to process this Pull Request

@krzksz
Copy link
Contributor

krzksz commented Dec 16, 2019

Hello @engcom-Charlie, the issue is reproductible:
obraz
It seems like either your screen is too wide or integration name is not long enough. It is a corner case, but still...

@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Dec 16, 2019

@krzksz yes, you are right.
image

Thank you for contribution and collaboration!

@engcom-Charlie
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Dec 19, 2019

Hi @divyajyothi5321, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: i95Dev partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants