Fix caching Magento Metadata getVersion

[luklewluk]

Fix caching result in ProductMetadata::getVersion.

Description (*)

My change fixes issue that getVersion result never gets cached.

Original Pull Request: #24030
Caching was broken by this commit: 37f6f6a

In order to fix the issue, we should put that line where it was originally.

Fixed Issues (if relevant)

1. Slow Performance of ProductMetadata::getVersion #24025: Slow Performance of ProductMetadata::getVersion

Manual testing scenarios (*)

1. have a module installed that relies on the product version to determine e.g. feature compatibility
2. profile uncached requests

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @luklewluk. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[kalpmehta]

Hi @luklewluk, thanks for your contribution! Please sign the Adobe CLA so we can process this PR.

[m2-assistant]

Hi @luklewluk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

Hi @luklewluk,
Thank you for contribution! As for me - your changes looks good.

As as part of #24030 changes weren't covered with unit tests - we got regression very soon. In order to prevent such situation in future - could you cover these changes with unit test?

Also please review failing tests and adjust your code / tests to make them pass.

[luklewluk]

Hi @ihor-sviziev
I have added unit tests and modified the class description so it passed Static Tests. Please check if it's okay now.
Thanks!

[magento-engcom-team]

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6463 has been created to process this Pull Request

[magento-engcom-team]

@luklewluk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

[engcom-Charlie]

✔️ QA Passed

[m2-assistant]

Hi @luklewluk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[erikhansen]

For the record, turning this PR into a patch and applying it to 2.3.3 resolved this issue for me. More details here.