Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous operation validate #25940

Conversation

sedonik
Copy link
Contributor

@sedonik sedonik commented Dec 6, 2019

Description

Added Magento\AsynchronousOperations\Model\OperationStatusPool and Magento\AsynchronousOperations\Model\OperationStatusValidator classes.
Added list of statuses to Magento\AsynchronousOperations\Model\OperationStatusPool with di.xml file.
Added validation to Magento\AsynchronousOperations\Model\Operation::setStatus method.

Fixed Issues

  1. magento/async-import#100: Add Operation Status validator

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 6, 2019

Hi @sedonik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@sedonik
Copy link
Contributor Author

sedonik commented Dec 6, 2019

Hi @nuzil ,

I've created new PR similar to https://github.com/magento/async-import/pull/110.
Could you check, please?

Thanks.

@sedonik sedonik requested a review from nuzil December 6, 2019 18:22
@nuzil nuzil self-assigned this Dec 6, 2019
@nuzil
Copy link
Contributor

nuzil commented Dec 6, 2019

Let’s wait for tests to finish. But I am for it

@magento-engcom-team
Copy link
Contributor

Hi @nuzil, thank you for the review.
ENGCOM-6439 has been created to process this Pull Request
✳️ @nuzil, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost added the Progress: accept label Dec 13, 2019
@magento-engcom-team magento-engcom-team merged commit b1e518c into magento:2.4-develop Dec 18, 2019
@m2-assistant
Copy link

m2-assistant bot commented Dec 18, 2019

Hi @sedonik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants