Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tag name #25895

Merged
Merged

Conversation

AndreyChorniy
Copy link
Contributor

@AndreyChorniy AndreyChorniy commented Dec 4, 2019

Description (*)

This PR fixes the unnecessary issue in exeption.log

Fixed Issues (if relevant)

  1. DOMDocument::loadHTML(): Tag date invalid in Entity #25738: DOMDocument::loadHTML(): Tag date invalid in Entity
  2. Magento Framework Escaper - Critical log with special symbols #13269 Magento Framework Escaper - Critical log with special symbols

Manual testing scenarios (*)

  1. Create a new customer or Login with an existing (user should be logged in)
  2. Place order
  3. Go to Order view page (you can delete exeption.log before)
  4. Check exeption.log (It should not contain DOMDocument::loadHTML(): Tag date invalid in Entity)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Dec 4, 2019

Hi @AndreyChorniy. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: Sales Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Dec 4, 2019
@rogyar rogyar self-assigned this Dec 4, 2019
@AndreyChorniy AndreyChorniy mentioned this pull request Dec 4, 2019
4 tasks
@rogyar
Copy link
Contributor

rogyar commented Dec 4, 2019

Hi @AndreyChorniy. As far as I see, it's a modified version of your previous PR created from the correct branch.

I've left some thoughts here. Basically, I agree with the idea.

Thank you

@rogyar
Copy link
Contributor

rogyar commented Dec 4, 2019

@AndreyChorniy could I kindly ask you to cover your change by MFTF test, please? You will also receive more contributor points for your change in case of the additional coverage.

Thank you!

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:05
@ihor-sviziev ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests and removed Progress: needs update labels Feb 13, 2020
@engcom-Charlie engcom-Charlie self-assigned this Feb 17, 2020
@engcom-Charlie
Copy link
Contributor

engcom-Charlie commented Feb 17, 2020

Hi @rogyar, could You please review test coverage?

@rogyar rogyar added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Feb 22, 2020
@magento-engcom-team
Copy link
Contributor

Hi @rogyar, thank you for the review.
ENGCOM-6958 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2020

Hi @AndreyChorniy, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Component: Sales Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants