-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change tag name #25895
Change tag name #25895
Conversation
Hi @AndreyChorniy. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hi @AndreyChorniy. As far as I see, it's a modified version of your previous PR created from the correct branch. I've left some thoughts here. Basically, I agree with the idea. Thank you |
@AndreyChorniy could I kindly ask you to cover your change by MFTF test, please? You will also receive more contributor points for your change in case of the additional coverage. Thank you! |
Hi @rogyar, could You please review test coverage? |
3d8a5fa
to
7ccff87
Compare
7ccff87
to
e537a76
Compare
Hi @rogyar, thank you for the review. |
✔️ QA passed |
Hi @AndreyChorniy, thank you for your contribution! |
Description (*)
This PR fixes the unnecessary issue in exeption.log
Fixed Issues (if relevant)
Manual testing scenarios (*)
It should not contain DOMDocument::loadHTML(): Tag date invalid in Entity
)Contribution checklist (*)