-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composer dependency to fix Redis Key Expiery #25488
Update composer dependency to fix Redis Key Expiery #25488
Conversation
I experienced a situation on production system with 15 stores and organic trafic, where the redis cache grows to over 30GB. It looks like magento is putting a lot of entries into the redis cache without any expiary. I needed to limit redis memory to prevent the server from dying, not how it should be. This had some performance influences. For this issue there is actualy a fix in place which just need to be pulled in. This commit is do this. With the fix in place the redis stabalized at arround 3GB. Over all performance is was also increased with this change. Referces: [1] colinmollenhour/Cm_Cache_Backend_Redis@bc63e72 [2] magento@32058c7 [3] magento#25487
Hi @toxix. Thank you for your contribution
For more details, please, review the Magento Contributor Guide documentation. |
Hey @buskamuza , Can you let me know when do you plan to do the code review? So I can resolve the conflicting composer.lock at that time. happy coding |
Hi @toxix, |
Hi, @toxix Could you resolve merge conflicts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/colinmollenhour/Cm_Cache_Backend_Redis/compare/1.10.0..1.11.0
No backwards-incompatible changes between the versions.
Hi @engcom-Alfa, Could you before testing merge it with accepting any part of "content-hash", and then run I think it's not worth asking author again and again |
@engcom-Alfa looks like you didn't ran |
Please resolve conflicts and check that all tests are passing |
@VladimirZaets please see #25488 (comment) |
@toxix @ihor-sviziev I agree that this file should be regenerated before delivery but we added additional tests and to make sure they are passing we need to have this conflict resolved once more time. |
…redis-prevent-growing # Conflicts: # composer.lock
@slavvka updated. |
Hi @lbajsarowicz, thank you for the review. |
4affd6f
to
46b3c3d
Compare
46b3c3d
to
75aa464
Compare
@engcom-Foxtrot I think we need to regenerate |
75aa464
to
a8f1ee7
Compare
…dis-prevent-growing # Conflicts: # composer.lock
Hi @toxix, thank you for your contribution! |
Description (*)
I experienced a situation on production system with 15 stores and
organic trafic, where the redis cache grows to over 30GB. It looks like
magento is putting a lot of entries into the redis cache without any
expiary. I needed to limit redis memory to prevent the server from
dying, not how it should be. This had some performance influences.
For this issue there is actualy a fix in place which just need to be
pulled in. This commit is do this. With the fix in place the redis
stabalized at arround 3GB. Over all performance is was also increased
with this change.
Referces:
[1] colinmollenhour/Cm_Cache_Backend_Redis@bc63e72
[2] 32058c7
[3] #25487
Fixed Issues (if relevant)
Manual testing scenarios (*)
Questions or comments
Contribution checklist (*)