Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix additional product options tooltip visibility #25393

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix additional product options tooltip visibility #25393

merged 1 commit into from
Nov 7, 2019

Conversation

torhoehn
Copy link
Contributor

Description (*)

Fixed Issues (if relevant)

  1. Product Additional Options Tooltip not fully visible #25392: Product Additional Options Tooltip not fully visible

Manual testing scenarios (*)

  1. Create a product that includes an additionalOption value that is over 55 characters
  2. Place order for product
  3. View invoice for order in customer dashboard

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Oct 31, 2019

Hi @torhoehn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-6216 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Oct 31, 2019
@engcom-Bravo engcom-Bravo self-assigned this Oct 31, 2019
@engcom-Bravo
Copy link
Contributor

Hello @torhoehn. Thank You for Your contribution. The PR really fixes issue #25392 as it is supposed to. But there is one more issue remaining in this case. As You may see it from the image from the Expected Result of #25392
Screenshot 2019-10-31 at 08 39 21
there is a whole html tag of <a href="#" class="dots tooltip toggle" onclick="return false">...</a> passed as a part of the customizable option text instead of supposedly only ... that when clicked on had to fully reveal the text and hide the tooltip (or do something similar).
Though probably this related issue deserves a separate PR I'll still try to ask You could You please fix it too. Thank You.

@torhoehn
Copy link
Contributor Author

@engcom-Bravo
Thanks for approving this PR. Thanks for the mention of the html tag, it's already mentioned in #25050. I'll try to fix this.

@engcom-Bravo
Copy link
Contributor

Thank You @torhoehn. And how would You prefer - to fix it in the current PR or in the new one?

@torhoehn
Copy link
Contributor Author

@engcom-Bravo I think it's more clear to fix it in a separate PR.

@engcom-Bravo
Copy link
Contributor

Ok, @torhoehn, then we process this one further. Thank You for the work done.

@engcom-Bravo
Copy link
Contributor

✔️ QA Passed.

@m2-assistant
Copy link

m2-assistant bot commented Nov 7, 2019

Hi @torhoehn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.4 milestone Nov 7, 2019
@torhoehn torhoehn deleted the feature/additional-product-options-tooltip branch November 7, 2019 05:32
@engcom-Bravo engcom-Bravo mentioned this pull request Nov 7, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants