Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning when Search Terms page is opened by clicking option at the footer #25246

Merged
merged 7 commits into from Feb 13, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 23, 2019

Description (*)

Fixed Issues (if relevant)

  1. Warning when Search Terms page is opened by clicking option at the footer #25245 Warning when Search Terms page is opened by clicking option at the footer

Manual testing scenarios (*)

  1. Setup vanilla 2.3-develop
  2. Create a product in the backend, give it the name "test"
  3. On the frontend, perform a search query, search for "test"
  4. Notice that it finds the product
  5. If you now go to the Search Terms page in the frontend, it will show the search term "test" => good
  6. Now in the backend, go to Marketing > SEO & Search > Search Terms
  7. Open your "test" term
  8. Set the "Number of Uses" to 0 and save
  9. Click On Search terms option present at the bottom

1. Page opens without any error
2. There is no errors in the system log

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@ghost ghost requested a review from kokoc as a code owner October 23, 2019 15:33
@m2-assistant
Copy link

m2-assistant bot commented Oct 23, 2019

Hi @vishalverma279. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

@VladimirZaets
Copy link
Contributor

Hi @vishalverma279.
Thanks for collaboration.
The processing of this PR will be after the issue will be confirmed

@ghost
Copy link
Author

ghost commented Oct 29, 2019

@VladimirZaets please check as the issue has been verified: #25245

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:17
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vishalverma279,
Here is still an issue that variable $termKeys should be initialized with an empty array. Could you update your PR accordingly?

@ghost ghost assigned ihor-sviziev Jan 27, 2020
@engcom-Golf engcom-Golf self-assigned this Feb 7, 2020
@engcom-Golf engcom-Golf changed the title #25245 fixed Warning when Search Terms page is opened by clicking option at the footer Feb 7, 2020
@engcom-Golf engcom-Golf added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Feb 7, 2020
@ghost ghost removed the Progress: needs update label Feb 10, 2020
@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-6842 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:
before

After:
after

@m2-assistant
Copy link

m2-assistant bot commented Feb 13, 2020

Hi @vishalverma279, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants