fixed issue #24438 - Duplicate product issues with different values for stores

[ghost]

Duplicate product issues with different values for stores

Description (*)

Fixed Issues (if relevant)

1. magento/magento2#24438: Duplicate product issues with different values for stores

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @webkul-paul. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[hostep]

Just FYI: removing those extra save() calls per storeview, should probably also fix: #22178 (comment)

[ihor-sviziev]

@magento give me test instance

[magento-engcom-team]

Hi @ihor-sviziev. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @ihor-sviziev, here is your new Magento instance.
Admin access: https://pr-24505.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[ihor-sviziev]

Hi @webkul-paul,
I just checked on test instance - issue wasn't solved.

In the admin URL key value has been set to correct value:

But on store view still not correct URL for DE store view:

Could you double check it?

I just checked it on test instance:
Original product:
https://pr-24505.instances.magento-community.engineering/test-product.html

Duplicated product:
https://pr-24505.instances.magento-community.engineering/test-product-1.html

[ihor-sviziev]

Hi @webkul-paul,
I just found another PR that fixes pretty similar issue - #23209
Looks like changes from this PR might fix issue that I described above.

Could you collaborate with @JeroenVanLeusden to prepare fix for both issues?

[ihor-sviziev]

Hi @webkul-paul,

These changes looks not correct because Catalog module should NOT depends on \Magento\UrlRewrite module where it possible.

Please review following changes in PR:
https://github.com/magento/magento2/pull/23209/files#diff-020e82e88f37d63ab5a890add8b92b53R160-R169
Looks like these changes should fix the issue you've got.

[sidolov]

@webkul-paul I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

[m2-assistant]

Hi @webkul-paul, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.