Fixed issue: Magento backend catalog "MSRP" without currency symbol

[00F100]

In this PR fix values of special_price and msrp into products list admin

Description (*)

The values of special_price and msrp into admin products list

Fixed Issues (if relevant)

1. Magento backend catalog "MSRP" without currency symbol #21910: Magento backend catalog "MSRP" without currency symbol

Manual testing scenarios (*)

1. Admin Menu > Stores > Configuration > Sales > Sales > Minimum Advertised Price = Yes
2. Navigate to admin catalog product grid
3. Using "Columns" selection, add 'Manufacturer's Suggested Retail Price'(MSRP) column in the grid

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @00F100. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[magento-cicd2]

All committers have signed the CLA.

[00F100]

@magento give me test instance

[magento-engcom-team]

Hi @00F100. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @00F100, here is your new Magento instance.
Admin access: https://pr-24379.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[orlangur]

@00F100 is it still an issue considering #20906 (comment)?

[00F100]

in this pr fix 3 columns: cost, special_price and msrp, not only cost.

[00F100]

if cost has been fixed, i remove from this PR

[orlangur]

@00F100 did you find commits where Cost was fixed? Would be nice to make fix consistent with core one.

[00F100]

yes, equals except here extends Price, not send all to Price class.

[rodrigowebjump]

@00F100 Please try to follow the fix approach used in https://github.com/magento/magento2/pull/20907/files

Const NAME is the component name, not the column name that can be defined by xml file.

[00F100]

@rodrigowebjump now it's good?

[00F100]

@magento give me test instance

[magento-engcom-team]

Hi @00F100. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @00F100, here is your new Magento instance.
Admin access: https://pr-24379.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[00F100]

CLA is empty :(

[00F100]

CLA not working

[orlangur]

This fix is incorrect and similar to https://github.com/magento/magento2/pull/20907/files.

In a proper fix, like it was made for Cost, new columns will not be added to grid by default.

Please specify commits where it was fixed for Cost and do a similar fix for Special Price and MSRP.

[rodrigowebjump]

@magento give me test instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your new Magento instance.
Admin access: https://pr-24379.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[rodrigowebjump]

@magento give me 2.3-develop instance

[magento-engcom-team]

Hi @rodrigowebjump. Thank you for your request. I'm working on Magento 2.3-develop instance for you

[magento-engcom-team]

Hi @rodrigowebjump, here is your Magento instance.
Admin access: https://i-24379-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

[00F100]

@orlangur please, help me. In version 2.3-develop Cost not formated and i not find commit to change Cost how do you say.

[00F100]

@magento give me test instance

[magento-engcom-team]

Hi @00F100. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @00F100, here is your new Magento instance.
Admin access: https://pr-24379.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[00F100]

@magento give me test instance

[magento-engcom-team]

Hi @00F100. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @00F100, here is your new Magento instance.
Admin access: https://pr-24379.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[orlangur]

@00F100, sorry, I don't have time to do it instead of you. Try searching using info from #20906 (comment), probably something was mentioned in git log.

[m2-assistant]

Hi @00F100, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[orlangur]

Sorry @00F100, I would like to find an accordance here with you.

magento 2.3.3 is not on github

I wasn't aware, sorry, just saw the #20906 (comment) which is from July.

I don't know what was the way to fix it in 2.3.3, this issue may be even irreproducible then. What I know for sure is that adding columns to grid (even invisible ones) is not a proper solution.

To find a proper solution let's wait for a release publishing, I'll ask EngCom guys in Slack if there is any ETA.