Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Catalog|Sales] Fix wrong behavior of grid row click event #22990

Conversation

Den4ik
Copy link
Contributor

@Den4ik Den4ik commented May 23, 2019

Description (*)

Fixed issue related with grid row click event when impossible to select input field value and checkbox in grid row

Fixed Issues (if relevant)

  1. Wrong behavior of grid row and checkbox click #22988: Wrong behavior of grid row and checkbox click

Manual testing scenarios (*)

  1. Go to Catalog->Categories page
  2. Open Products in Category fieldset
  3. Try to select value in position field with mousup not above input field
    Same steps for admin order create page with Assign products

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented May 23, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@Den4ik
Copy link
Contributor Author

Den4ik commented May 23, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, here is your Magento instance.
Admin access: https://i-22990-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@Den4ik Den4ik force-pushed the bug/wrong-behavior-of-grid-row-click branch from c8c7573 to e9bbf40 Compare May 23, 2019 13:33
@Den4ik
Copy link
Contributor Author

Den4ik commented May 23, 2019

@magento-engcom-team give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @Den4ik, here is your new Magento instance.
Admin access: https://pr-22990.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@Den4ik Den4ik force-pushed the bug/wrong-behavior-of-grid-row-click branch from e9bbf40 to 0105e4c Compare May 23, 2019 14:11
@VladimirZaets VladimirZaets self-assigned this May 23, 2019
@Den4ik
Copy link
Contributor Author

Den4ik commented Jun 7, 2019

@VladimirZaets Any updates with PR?

@Den4ik Den4ik requested a review from VladimirZaets June 24, 2019 20:45
@Den4ik Den4ik requested a review from sidolov July 9, 2019 08:24
@Den4ik
Copy link
Contributor Author

Den4ik commented Jul 23, 2019

@VladimirZaets Any progress?

@ghost ghost assigned sidolov Oct 4, 2019
@magento-engcom-team
Copy link
Contributor

Hi @sidolov, thank you for the review.
ENGCOM-6007 has been created to process this Pull Request
✳️ @sidolov, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-6007 has been created to process this Pull Request

@engcom-Delta
Copy link
Contributor

✔️ QA passed

@engcom-Foxtrot
Copy link
Contributor

@magento run all tests

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:20
@ghost ghost assigned krzksz Dec 9, 2019
@slavvka
Copy link
Member

slavvka commented Dec 9, 2019

Guys, thank you for patience. This PR is delivery queue

@slavvka
Copy link
Member

slavvka commented Dec 9, 2019

@magento run all tests

@m2-assistant
Copy link

m2-assistant bot commented Jan 9, 2020

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@Den4ik Den4ik deleted the bug/wrong-behavior-of-grid-row-click branch January 9, 2020 10:57
@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants