-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for update products via csv file (fix for 22028) #22902
Fix for update products via csv file (fix for 22028) #22902
Conversation
Hi @mtwegrzycki. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
Hi @orlangur , I marked you in comment, because you know this case from PR for Magento 2.3 version. |
Please, let me know, if any additional actions from me are required. |
Hi @rogyar, thank you for the review. |
✔️ QA Passed |
Hi @mtwegrzycki, thank you for your contribution! |
Description (*)
It is backport pull request related to #22575 PR (on Magento 2.3)
It is fix for issue #22028
In query for selecting ids to indexing after import products, I changed "between" into "in",
Before change, when products were updated via csv file import in Admin panel, to indexing process were selected all products from range between the smallest and the biggest products id from csv file. When the ids were from wide range, it caused selecting a huge amount of data and attempt to inserting them to catalog_product_index_price_temp. If data amount was to big, it caused error
After change, for indexing process are selected only products from csv file.
Example:
Before change, when we try to update two products with id 30 and 31, only two products were selected to indexing.
When products have ids 30 and 50, it caused, that 21 products were selected to indexing (All products with ids between 30 and 50.
After change, in both cases described above, only two products will be selected to indexing.
Fixed Issues (if relevant)
No related issues found.
Manual testing scenarios (*)
The same scenario can be applied to reproduce bug and check fix:
Contribution checklist (*)