Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

magento/magento2#22010: Updates AbstractExtensibleObject and AbstractExtensibleModel annotations #22011

Merged
merged 6 commits into from
Mar 25, 2020
Merged

magento/magento2#22010: Updates AbstractExtensibleObject and AbstractExtensibleModel annotations #22011

merged 6 commits into from
Mar 25, 2020

Conversation

atwixfirster
Copy link
Contributor

Issue: #22010

Thank you!

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Mar 28, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @atwixfirster. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added Component: Model Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Release Line: 2.3 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Mar 28, 2019
@atwixfirster atwixfirster requested a review from maghamed March 28, 2019 13:50
@orlangur orlangur self-assigned this Mar 28, 2019
@orlangur
Copy link
Contributor

Not sure it can be delivered this way in a patch release, in the meantime please sign CLA.

@atwixfirster
Copy link
Contributor Author

in the meantime please sign CLA.

done

Thank you, @orlangur

@atwixfirster
Copy link
Contributor Author

@orlangur, any updates here?

Thank you!

@orlangur
Copy link
Contributor

@magento run all tests

@sidolov sidolov changed the base branch from 2.3-develop to 2.4-develop December 5, 2019 17:21
@atwixfirster
Copy link
Contributor Author

@orlangur , could you please clarify what is a further fate of this PR?

It has been opened 10 months ago and still have HOLD status. What are we waiting for? :))

Thank you!

lenaorobei
lenaorobei previously approved these changes Mar 9, 2020
View reviewed changes
@ghost ghost assigned lenaorobei Mar 9, 2020
@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7071 has been created to process this Pull Request
✳️ @lenaorobei, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@lenaorobei lenaorobei added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Mar 9, 2020
@engcom-Alfa engcom-Alfa self-assigned this Mar 11, 2020
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@ghost ghost added the Progress: to approve label Mar 11, 2020
@engcom-Charlie
Copy link
Contributor

It should be approved, Static Tests failed with error:

Abstract classes MUST NOT be marked as public @api.

@lenaorobei
Copy link
Contributor

Please add ignore annotations to this classes, since it is a recommended way to use AbstractExtensibleModel abstract class.

@atwixfirster
Copy link
Contributor Author

Please add ignore annotations to this classes, since it is a recommended way to use AbstractExtensibleModel abstract class.

done

lenaorobei
lenaorobei reviewed Mar 13, 2020
View reviewed changes
lib/internal/Magento/Framework/Api/AbstractExtensibleObject.php Outdated
@@ -12,6 +12,7 @@
*
* @SuppressWarnings(PHPMD.NumberOfChildren)
* @api
* @codeCoverageIgnore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @codeCoverageIgnore
* phpcs:disable Magento2.Classes.AbstractApi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@lenaorobei , could you please review? Thank you!

@magento-engcom-team
Copy link
Contributor

Hi @lenaorobei, thank you for the review.
ENGCOM-7071 has been created to process this Pull Request

@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

@engcom-Echo engcom-Echo self-assigned this Mar 23, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Mar 25, 2020
Closed
magento-engcom-team pushed a commit that referenced this pull request Mar 25, 2020
@slavvka
ENGCOM-7071: #22010: Updates AbstractExtensibleObject and AbstractExt…
e58c413 
…ensibleModel annotations #22011
@magento-engcom-team magento-engcom-team merged commit 816338c into magento:2.4-develop Mar 25, 2020
@m2-assistant
Copy link

m2-assistant bot commented Mar 25, 2020

Hi @atwixfirster, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@sdzhepa sdzhepa mentioned this pull request May 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenaorobei lenaorobei lenaorobei approved these changes

@maghamed maghamed Awaiting requested review from maghamed

Assignees

@orlangur orlangur

@lenaorobei lenaorobei

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Echo engcom-Echo

Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Component: Model Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@atwixfirster @magento-cicd2 @magento-engcom-team @orlangur @engcom-Alfa @engcom-Charlie @lenaorobei @sidolov @engcom-Echo