Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed-19379-Tax Rate Checkbox alignment issue #19383

Closed

Conversation

suryakant-krish
Copy link
Contributor

Description (*)

Tax Rate Checkbox alignment issue

Fixed Issues (if relevant)

  1. magento/magento2#Tax Rate Checkbox alignment issue. #19379: Tax Rate Checkbox alignment issue

Manual testing scenarios (*)

  1. Login into admin panel > Stores > Tax Rules > Click on Add New Tax Rule > Click on Add New Tax Rate
  2. Alignment Issue "Zip/Post is Range" Checkbox.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @suryakant-krish. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

@suryakant-krish can you please port this pull request to 2.3-develop branch, it should be merged to 2.3 first.

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Dec 28, 2018

CLA assistant check
All committers have signed the CLA.

magento-engcom-team added a commit that referenced this pull request Jan 14, 2019
…ssue #19383 #19413

 - Merge Pull Request #19413 from suryakant-krish/magento2:fixed-2.3-dev-19379
 - Merged commits:
   1. d0d8725
magento-engcom-team added a commit that referenced this pull request Jan 14, 2019
…ssue #19383 #19413

 - Merge Pull Request #19413 from suryakant-krish/magento2:fixed-2.3-dev-19379
 - Merged commits:
   1. d0d8725
   2. 8b7e683
magento-engcom-team added a commit that referenced this pull request Jan 14, 2019
…ssue #19383 #19413

 - Merge Pull Request #19413 from suryakant-krish/magento2:fixed-2.3-dev-19379
 - Merged commits:
   1. d0d8725
   2. 8b7e683
   3. 02384d7
   4. 734e95e
@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 21, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 21, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 21, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 21, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 21, 2019 via email

@priti2jcommerce
Copy link
Contributor

priti2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 21, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 21, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 21, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@dipti2jcommerce
Copy link

dipti2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@nainesh2jcommerce
Copy link
Contributor

nainesh2jcommerce commented Feb 21, 2019 via email

@prakash2jcommerce
Copy link

prakash2jcommerce commented Feb 21, 2019 via email

@ajay2jcommerce
Copy link

ajay2jcommerce commented Feb 21, 2019 via email

@nilesh2jcommerce
Copy link

nilesh2jcommerce commented Feb 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.