Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] Fix adding values to system variable collection unit test. #17093

Closed
wants to merge 1 commit into from
Closed

[Backport] Fix adding values to system variable collection unit test. #17093

wants to merge 1 commit into from

Conversation

mageprince
Copy link
Contributor

Original Pull Request

#13742

Unit test, which covers code changes made in #13596
2.3-develop: #13735

Description

Test for Magento\Variable\Model\ResourceModel\Variable\Collection::addValuesToResult().

Fixed Issues (if relevant)

None.

Manual testing scenarios

None.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sidolov
Copy link
Contributor

sidolov commented Jul 25, 2018

@mageprince , please, fix test according to PHPUnit version that used in current release line.

@sidolov
Copy link
Contributor

sidolov commented Aug 8, 2018

Hi @mageprince , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for the collaboration!

@sidolov sidolov closed this Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants