[Backport] FIX for issue#14869 - Wrong price at backend after update #16895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…commit 9d3be73 changed the default behaviour of \Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote. The current fix restore the previous behaviour and adds a check if the quote is not specified.
| @@ -61,6 +67,7 @@ public function __construct( | |||
| \Magento\Quote\Model\ResourceModel\Quote\Item\Option\CollectionFactory $itemOptionCollectionFactory, | |||
| \Magento\Catalog\Model\ResourceModel\Product\CollectionFactory $productCollectionFactory, | |||
| \Magento\Quote\Model\Quote\Config $quoteConfig, | |||
| \Magento\Store\Model\StoreManagerInterface $storeManager = null, | |||
There was a problem hiding this comment.
Hi @mage2pratik, thanks for collaboration. The optional parameter should be passed last in the params list, currently, it's backward-incompatible changes
|
Hi @mage2pratik , please, take a look at failed test |
|
Hi @mage2pratik , I am closing this PR now due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Pull Request
#14904
A previous commit 9d3be73 (cc @neeta-wagento) changed the default behaviour of
\Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId()using the store coming from the current sessioninstead of using the one from quote. The previous commit was made to fix an error while using
getItems()without setting a quote.The implemetation is correctly working in the frontend because the quote storeId is and the session storeId are matchnig, but it breaks the admin implementation because they can be different.
The current fix restore the previous behaviour and adds a check if the quote is not specified.
Fixed Issues (if relevant)
Contribution checklist