Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forwardport] Fix case mismatch call (class/method) #16363

Merged
merged 1 commit into from
Jul 18, 2018
Merged

[Forwardport] Fix case mismatch call (class/method) #16363

merged 1 commit into from
Jul 18, 2018

Conversation

lfluvisotto
Copy link
Contributor

Original Pull Request

#16141

Description

Fix case mismatch call (class/method), code quality.

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me {$VERSION} instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ihor-sviziev ihor-sviziev requested a review from sidolov June 26, 2018 13:37
sidolov
sidolov reviewed Jul 12, 2018
View reviewed changes
Copy link
Contributor

@sidolov sidolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good for me

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jul 12, 2018
@magento-engcom-team magento-engcom-team merged commit 0a48caf into magento:2.3-develop Jul 18, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 18, 2018
ENGCOM-2309: [Forwardport] Fix case mismatch call (class/method) #16363
41b79f0
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidolov sidolov sidolov left review comments

Assignees

@sidolov sidolov

Labels
Cleanup Component: multiple improvement Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lfluvisotto @magento-engcom-team @sidolov