Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPDoc #16215

Merged
Merged

Conversation

lfluvisotto
Copy link
Contributor

@lfluvisotto lfluvisotto commented Jun 18, 2018

Description

PHPDoc in methods that were missing

@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@orlangur
Copy link
Contributor

Nice 👍 And then I'll perform another attempt on delivering #9367 into 2.2-develop :)

@VladimirZaets
Copy link
Contributor

Hi, @lfluvisotto, I took your PR into processing, thank you for collaboration. Great job!

@magento-engcom-team magento-engcom-team merged commit 0e9ed86 into magento:2.2-develop Jun 22, 2018
magento-engcom-team pushed a commit that referenced this pull request Jun 22, 2018
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

This was referenced Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants