Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed double occurrence of keywords from sentences. #16182

Conversation

sanganinamrata
Copy link
Member

@sanganinamrata sanganinamrata commented Jun 16, 2018

Description

Removed double occurrence of keywords "to, the" from sentences.

Fixed Issues (if relevant)

N/A

Manual testing scenarios

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Area: Frontend Area: Lib/Frontend Component: Customer Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Component: Setup Component: Integration labels Jun 16, 2018
@magento-engcom-team
Copy link
Contributor

Hi @namratachangani. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on Pull Request changes
  • @magento-engcom-team give me new test instance - deploy NEW test instance based on Pull Request changes
  • @magento-engcom-team give me {$VERSION} instance - deploy Vanilla Magento instance for Issue or Pull Request

For more details, please, review the Magento Contributor Assistant documentation

@sanganinamrata sanganinamrata changed the title Removed double occurrence of keywords in sentences. Removed double occurrence of keywords from sentences. Jun 16, 2018
@orlangur orlangur self-assigned this Jun 17, 2018
Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! @namratachangani how did you find these occurrences? Is there some automation for spellchecking available probably? :)

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-2018 has been created to process this Pull Request

@sanganinamrata
Copy link
Member Author

@orlangur Hello,

While working with theme/module, I saw some double occurrence of the same keywords, So I find in the whole directory for the same double occurrence(Using PhpStorm), and replaced it with a single occurrence where necessary.

Thank you :)

@magento-engcom-team
Copy link
Contributor

Hi @namratachangani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants