Do not display anchor if admin submenu has no children #15933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magento-engcom-team
added
Partner: Atwix
magento-engcom-team
pushed a commit
that referenced
this pull request
Jun 11, 2018
|
Hi @rogyar. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the admin panel if some submenu has no items it's still shown in the menu. Out of the box, we have "Other Settings" submenu in the "Stores" menu which is empty and looks not very good.
The fix prevents rendering submenus with no items (the same behavior we have within a scope of versions 2.2 and 2.3)
Manual testing scenarios
Preconditions: Magento 2.1.x
Expected behavior
There are no empty submenus
Actual behavior
There's an empty "Other Settings" submenu item with "dimmed" title.