Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] [Resolved : limiter float too generic] #15879

Conversation

hitesh-wagento
Copy link
Contributor

Original Pull Request

#15878

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Description

Added selector for floating the element .limiter

Fixed Issues (if relevant)

  1. magento/magento2#limiter float too generic #15323: Issue title limiter float too generic

Manual testing scenarios

  1. inspect toolbar in product list
  2. compare styles of .limiter and .pages

Actual Result

.limiter is too generic and is used as single selector for floating the element

Expected Result

.limiter should have the same parent selectors like .pages to prevent clashes between styles and layouts

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@VladimirZaets
Copy link
Contributor

Hi, @hitesh-wagento , I took your PR into processing, thank you for collaboration.

@hitesh-wagento
Copy link
Contributor Author

@VladimirZaets Could you please check what cause failed travis?

Thanks,

@hitesh-wagento
Copy link
Contributor Author

@VladimirZaets

Any update in this PR ?

Thanks

@VladimirZaets
Copy link
Contributor

@hitesh-wagento Hi, I think it's the environment problems. We work on this PR. Thanks

@magento-engcom-team
Copy link
Contributor

Hi @hitesh-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

@hitesh-wagento hitesh-wagento deleted the 2.3-develop-PR-port-15878 branch September 6, 2018 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Design/Frontend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants