Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Refactor javascript code of button split widget #15731

Conversation

vijay-wagento
Copy link

Original Pull Request

#15351
Refactor javascript code of button split widget call js component

Description

Format the javascript code in the template file spli.phtml for button widget

Fixed Issues (if relevant)

  1. Issue Number Refactor javascript code of button split widget call js component #15354

Manual testing scenarios

  1. N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@vijay-wagento
Copy link
Author

@VladimirZaets Could you please rerun? Seems like it throws an error because of the timeout.

@magento-engcom-team
Copy link
Contributor

Hi @vijay-wagento. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Component: Backend Partner: Wagento Pull Request is created by partner Wagento partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants