Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forwardport] Fix HTML syntax in report.phtml error template #15701

Conversation

dmytro-ch
Copy link
Contributor

@dmytro-ch dmytro-ch commented Jun 3, 2018

Original PR: #15454

Added missing quotes to the div tags with class control.

Description

Added missing quotes to the class attribute of div tags in the default reporting template file in pub/errors/default/report.phtml

Fixed Issues (if relevant)

Manual testing scenarios

  1. Open in any editor with syntax highlighting, it shouldn't show any more syntax warnings.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmytro-ch dmytro-ch added Release Line: 2.3 partners-contribution Pull Request is created by Magento Partner Partner: Atwix Pull Request is created by partner Atwix labels Jun 3, 2018
@dmytro-ch dmytro-ch requested a review from rogyar June 3, 2018 07:31
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 3, 2018
@magento-engcom-team magento-engcom-team merged commit 09459f6 into magento:2.3-develop Jun 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.3.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants