Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Magnifier in inside mode #15382

Conversation

kacperchara
Copy link

@kacperchara kacperchara commented May 19, 2018

Fixed Issues

  1. Magnifier doesn't work with mode set to inner #4977: Magnifier doesn't work with mode set to inner

Manual testing scenarios

You need to change the magnifier's configuration options in the file: app/design/frontend/Magento/luma/etc/view.xml

Set the following values ​​for these lines:

<var name="enabled">true</var>
<var name="mode">inside</var>

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
All committers have signed the CLA.

@kacperchara
Copy link
Author

There is a problem with the license, although I signed it, it is still visible that the license has not been signed.

@dmanners
Copy link
Contributor

Hi @kacperchara it seems you committed with one user (https://github.com/kcharadivante) but are logged in and so signed the cla with another user (https://github.com/kacperchara)

@magento-engcom-team
Copy link
Contributor

Hi @kacperchara. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.5 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

@boostify-pro
Copy link

I am on 2.2.6 and still having this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants