Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXED - appended payment code to ID field to make it unique #15344

Merged
merged 1 commit into from
Jun 15, 2018

Conversation

rakesh-gangani
Copy link
Contributor

@rakesh-gangani rakesh-gangani commented May 19, 2018

Description

Fixed Issues (if relevant)

  1. In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method #13692: In payment step of checkout I cannot unselect #billing-save-in-address-book checkbox in non-first payment method

Manual testing scenarios

  1. Log in to your client account.
  2. Add product to cart.
  3. Go to checkout and click next button to be able to choose payment methods.
  4. Open payment method other than the first one.
  5. Uncheck My billing and shipping address are the same checkbox
  6. Choose New address on the billing address dropdown
  7. Fill address
  8. Click on label Save in address book

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented May 19, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @miguelbalparda, thank you for the review.
ENGCOM-1988 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @rakesh-gangani. Thank you for your contribution.
Changes from your Pull Request will be available with the upcoming 2.2.6 release.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants