Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] FIX for issue#14869 - Wrong price at backend after update #15111

Conversation

sergiy-v
Copy link
Contributor

@sergiy-v sergiy-v commented May 9, 2018

Original PR: #14904.

A previous commit 9d3be73 (cc @neeta-wagento) changed the default behaviour of
\Magento\Quote\Model\ResourceModel\Quote\Item\Collection::getStoreId() using the store coming from the current session
instead of using the one from quote. The previous commit was made to fix an error while using getItems() without setting a quote.
The implemetation is correctly working in the frontend because the quote storeId is and the session storeId are matchnig, but it breaks the admin implementation because they can be different.

The current fix restore the previous behaviour and adds a check if the quote is not specified.

Fixed Issues (if relevant)

  1. M 2.2.3 price per website - wrong price at backend by a create order after update #14869: Wrong price at backend after update

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@sergiy-v sergiy-v requested a review from rogyar May 9, 2018 13:14
@magento-engcom-team magento-engcom-team added this to the May 2018 milestone May 9, 2018
@magento-engcom-team magento-engcom-team added Release Line: 2.1 Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels May 9, 2018
@VladimirZaets
Copy link
Contributor

Hi @sergiy-v. As I see, the commit 9d3be is absent in the 2.1 branch, so this fix is no relevant.

Can you please make backport changes from the commit 9d3be too. Thanks

@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@VladimirZaets
Copy link
Contributor

@sergiy-v, I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration

@sergiy-v sergiy-v deleted the feature/2.1-wrong-price-at-backend-after-update branch February 28, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Progress: needs update Release Line: 2.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants