-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo cleanup for dev #13300
Merged
magento-engcom-team
merged 13 commits into
magento:2.3-develop
from
akiojalehto:fix/typos/dev
Jan 28, 2018
Merged
Typo cleanup for dev #13300
magento-engcom-team
merged 13 commits into
magento:2.3-develop
from
akiojalehto:fix/typos/dev
Jan 28, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanners
suggested changes
Jan 25, 2018
@@ -345,7 +345,7 @@ protected function preparePrice() | |||
} | |||
|
|||
/** | |||
* Preparation wheather product 'Is Virtual'. | |||
* Preparation weather product 'Is Virtual'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guess this should actually be whether.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, fixed this one in c3dc593 :)
dmanners
approved these changes
Jan 26, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Jan 28, 2018
This was referenced May 17, 2018
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanups continue. No breaking changes, just misspellings.
Contribution checklist