Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small refactor of getFrontName #13299

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Small refactor of getFrontName #13299

merged 1 commit into from
Jan 24, 2018

Conversation

akiojalehto
Copy link
Member

@akiojalehto akiojalehto commented Jan 21, 2018 •
edited
Loading

Description

getFrontName is an alias of getModuleName so we might as well return it's return value.
Both seems to be in use, but maybe one or the other should be deprecated?

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@dmanners dmanners self-assigned this Jan 24, 2018
@dmanners dmanners added this to the January 2018 milestone Jan 24, 2018
@magento-team magento-team merged commit c8bbc7a into magento:2.3-develop Jan 24, 2018
magento-team pushed a commit that referenced this pull request Jan 24, 2018
MAGETWO-87116: Small refactor of getFrontName #13299
102e56a
@mage2pratik mage2pratik mentioned this pull request Feb 17, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanners dmanners dmanners approved these changes

Assignees

@dmanners dmanners

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.
3 participants
@akiojalehto @dmanners @magento-team