Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

11941: Invoice for products that use qty decimal rounds down to whole number. #11997

Merged
merged 1 commit into from
Nov 16, 2017

Conversation

nmalevanec
Copy link
Contributor

Description

Fix for: Invoice for products that use qty decimal rounds down to whole number.

Fixed Issues (if relevant)

  1. Invoice for products that use qty decimal rounds down to whole number #11941: Invoice for products that use qty decimal rounds down to whole number

Manual testing scenarios

  1. Create a virtual product.
  2. In Advanced Inventory Qty Uses Decimals = Yes.
  3. In the admin create an order using the new product and pay with check/money order.
  4. Purchase a quantity of 6.5 of the product and complete the order.
  5. Start to create the invoice, check at the QTY invoiced it should not be rounded down to 6.
  6. Change "Qty to Invoice" to any decimal qty less than 6.5. Press "Update Qty's", check "Qty in Invoice" should not be rounded.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko self-assigned this Nov 14, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 14, 2017
@magento-team magento-team merged commit 0db2b08 into magento:2.2-develop Nov 16, 2017
magento-team pushed a commit that referenced this pull request Nov 16, 2017
magento-team pushed a commit that referenced this pull request Nov 16, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83959: Issue: 3596. Resolve Notice with undefined index 'value' #12296
 - MAGETWO-83957: #12083: Cannot import zero (0) value into custom attribute #12283
 - MAGETWO-83868: 11941: Invoice for products that use qty decimal rounds down to whole number. #11997
@nmalevanec nmalevanec deleted the 11941 branch August 21, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants