-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix syntax of expectException() calls #11099
Merged
magento-team
merged 7 commits into
magento:2.2-develop
from
schmengler:expect-exception-2.2
Dec 7, 2017
Merged
Fix syntax of expectException() calls #11099
magento-team
merged 7 commits into
magento:2.2-develop
from
schmengler:expect-exception-2.2
Dec 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expectException(); expectExceptionMessage()
expectException(); expectExceptionMessage()
…xpect-exception-2.2
Additionally fixed 41 file |
magento-team
pushed a commit
that referenced
this pull request
Dec 7, 2017
magento-team
pushed a commit
that referenced
this pull request
Dec 7, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-84981: Trying to get data from non existent products #12539 - MAGETWO-84979: [Backport 2.2-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12541 - MAGETWO-84903: Added namespace to product videos fotorama events #12469 - MAGETWO-84862: [Backport 2.2-develop] #11409: Too many password reset requests even when disabled in settings #11435 - MAGETWO-84856: Issue 12506: Fixup typo getDispretionPath -> getDispersionPath #12507 - MAGETWO-84808: 12110: Missing cascade into attribute set deletion. #12167 - MAGETWO-83503: [2.2] - Add command to view mview state and queue #12122 - MAGETWO-80223: Fix syntax of expectException() calls #11099
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 16, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 16, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(recreated #11068)
Description
RegEx search and replace from
( *)\$this->expectException\(([^\n,]+), ([^)\n]+)\);
to$1\$this->expectException($2);\n$1\$this->expectExceptionMessage($3);
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist