Option to send currency in Google Adwords when using dynamic value #10558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DominicWatts Thank you for this PR. Please take a look at the failed unit and static tests. |
|
The additional changes to the tests I made aren't quite right and I can't work out what's wrong |
|
@DominicWatts I will look into those issues and let you know what is wrong shortly. |
…value - Fixes per failed tests
…value - Fixes per failed tests
…value - Fixes per failed tests
ishakhsuvarov
requested changes
Aug 18, 2017
| @@ -59,6 +64,8 @@ class Data extends \Magento\Framework\App\Helper\AbstractHelper | |||
|
|
|||
| const XML_PATH_CONVERSION_VALUE = 'google/adwords/conversion_value'; | |||
|
|
|||
| const XML_PATH_SEND_CURRENCY = 'google/adwords/send_currency'; | |||
There was a problem hiding this comment.
Please add a docblock to the constant with the description of this setting.
| * | ||
| * @return boolean | ||
| */ | ||
| public function hasSendCurrency() |
There was a problem hiding this comment.
This naming is ambiguous, I would suggest looking for more descriptive method name.
| /** | ||
| * Get Google AdWords conversion value currency | ||
| * | ||
| * @return float |
There was a problem hiding this comment.
Docblock states return type float however method returns string or bool
ishakhsuvarov
approved these changes
Aug 19, 2017
…value - Fixes per failed tests
magento-team
pushed a commit
that referenced
this pull request
Aug 21, 2017
|
@magento-team Will this be backported to 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces option to send currency in adwords when using dynamic value to cope with multisite scenario where base currency differs between websites
Description
Introduce option to send currency in adwords when using dynamic value. Configurable via backend. Defaults to off.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist