Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product attribute notice translation #10274

Merged
merged 4 commits into from
Jul 20, 2017
Merged

Product attribute notice translation #10274

merged 4 commits into from
Jul 20, 2017

Conversation

michielgerritsen
Copy link
Member

@michielgerritsen michielgerritsen commented Jul 18, 2017

When adding a note/notice to a product attribute, this is never translated in the admin.

Description

I only added a __() to the existing variable.

Manual testing scenarios

  1. Create an attribute ($eavSetup->addAttribute()) with the note keyword (example).
  2. Add a translation in the i18n folder for this note.
  3. It is not translated, but it should.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jul 18, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko
Copy link
Contributor

okorshenko commented Jul 18, 2017

Hi @michielgerritsen
Could you please sign CLA so that we can proceed with PR acceptance?
Thank you

Please, pay attention that you committed the changes using tig-michielgerritsen account, but ob GitHub you are using michielgerritsen

@michielgerritsen
Copy link
Member Author

Hi @okorshenko,

Thank you for noticing, i just changed the author to be the same for all commits. The CLA is signed for this account.

@ishakhsuvarov ishakhsuvarov self-assigned this Jul 19, 2017
@ishakhsuvarov ishakhsuvarov added this to the July 2017 milestone Jul 19, 2017
@magento-team magento-team merged commit b4423f8 into magento:develop Jul 20, 2017
@michielgerritsen michielgerritsen deleted the product_attribute_notice_translation branch July 21, 2017 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants