-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed: Product attributes labels are not translated on product edit page #10184
Conversation
Hi @fernandofauth this PR almost similar to #10184 Which one is final? |
Ops, I'm sorry i tried splitting the commits on 2 PR. |
Additional information: Old code: http://prntscr.com/fsw41t New code:http://prntscr.com/fsw4w7 |
Travis rejected my changes on AbstractAttribute.php, and he's right. |
… product edit page #10184
Fixed issues: - MAGETWO-70543 Fixed: Product attributes labels are not translated on product edit page #10184
Good afternoon, This issue is still not fixed in Magento 2.2 Cheers |
You also need to update line 581. Catalog Attribute Note is not translated. |
The attributes on product page can't be translated.
Description
I found where the data is provided and I simple changed the return of function add the "___()", to be can be able translation by csv file.
Page: http://prntscr.com/fswiix
Code: http://prntscr.com/fswivh
CSV: http://prntscr.com/fswjdj
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist