Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Product attributes labels are not translated on product edit page #10184

Merged
merged 5 commits into from
Jul 11, 2017
Merged

Fixed: Product attributes labels are not translated on product edit page #10184

merged 5 commits into from
Jul 11, 2017

Conversation

fernandofauth
Copy link
Contributor

@fernandofauth fernandofauth commented Jul 7, 2017

The attributes on product page can't be translated.

Description

I found where the data is provided and I simple changed the return of function add the "___()", to be can be able translation by csv file.

Page: http://prntscr.com/fswiix
Code: http://prntscr.com/fswivh
CSV: http://prntscr.com/fswjdj

Fixed Issues (if relevant)

  1. Product attributes' labels are not translated on product edit page #1980: Issue title: Product attributes' labels are not translated on product edit page

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Jul 7, 2017
@okorshenko
Copy link
Contributor

Hi @fernandofauth this PR almost similar to #10184 Which one is final?

@fernandofauth
Copy link
Contributor Author

Ops, I'm sorry i tried splitting the commits on 2 PR.
You can considerate only this commit? "Fixed: Product attributes labels are not translated on product edit page"

@okorshenko
Copy link
Contributor

Additional information:
Fixed bookmark translation on product list page.

Old code: http://prntscr.com/fsw41t
Translation problem: http://prntscr.com/fsw5jc

New code:http://prntscr.com/fsw4w7
Translation works: http://prntscr.com/fsw5ap

@fernandofauth
Copy link
Contributor Author

Travis rejected my changes on AbstractAttribute.php, and he's right.
In this way I removed the commit of AbstractAttribute.php .
And I found translations errors on the attribute group too.
I added all the fixes on this new commit.

@magento-team magento-team merged commit 5aadc6c into magento:2.1-develop Jul 11, 2017
magento-team pushed a commit that referenced this pull request Jul 11, 2017
magento-team pushed a commit that referenced this pull request Jul 11, 2017
Fixed issues:
- MAGETWO-70543 Fixed: Product attributes labels are not translated on product edit page #10184
@Amadeco
Copy link

Amadeco commented Feb 23, 2018

Good afternoon,

This issue is still not fixed in Magento 2.2
Hopefully, the solution give @fernandofauth save a lot of time.

Cheers

@Amadeco
Copy link

Amadeco commented Feb 23, 2018

You also need to update line 581.

Catalog Attribute Note is not translated.
Must be :
'notice' => __($attribute->getNote()),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants