Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme list will not be updated #867

Closed
Crustymd opened this issue Dec 24, 2014 · 6 comments
Closed

Theme list will not be updated #867

Crustymd opened this issue Dec 24, 2014 · 6 comments
Assignees

Comments

@Crustymd
Copy link

So if i try to implement a template in Magento to i unzip it in root folder (if the template is full ready) and the files will be copied to needed directory and then after refresh magento cache you can see the template in Store - > Configuration -> Design -> Design Theme

It will appear in the list.

Now the issue is, i tried to create own template to see if i make it correctly, so i created a directory

app/design/frontend/crusty/firsttheme/

And in this direcotry i should create the other subdirectories of the teme acording to documentation. BUT i did not continue i just wanted to see how other template works first, so i left this directory Empty and installed a theme, refreshed cache, and the theme WOULD NOT appear in the Design Theme list.. Only the 2 magento default Themes were there... I cleared cache and e.t.c. but nthing would help

The strange thing is that you could see the Theme in Contect -> Design -> Theme
But you would not see it in the Design Theme list and you can not select it cause it is not there.

I just thought what might cause this, i delete my empty directory "app/design/frontend/crusty/" - refreshed cache, and it worked, the theme was in the theme list

So as i have understood, if there is a empty directory or incorectly, managed directory of a theme, Magento will Not update the Theme List.

Am not sure that you could call this a bug, but anyway i think magento should ignore the empty directory, skip it, and yet update the theme list with those that are correctly setted up.

@Vinai
Copy link
Contributor

Vinai commented Dec 24, 2014

You currently need to create a compose.json and register the version from there (and the parent theme, if there is one). But that will be changed again according to this issue: #840
A PR is pending, too.

@wojtekn
Copy link
Contributor

wojtekn commented Dec 27, 2014

I've just spotted similar behavior when I was trying to update parent theme for custom theme which was already displayed on the list in Content -> Design -> Themes. I did following:

  1. Created theme containing composer.json and theme.xml files and set luma as parent theme in composer.json
  2. Refreshed Content -> Design -> Themes, successfully found my theme there
  3. Changed parent theme in composer.json to blank
  4. Cleared cache
  5. Refreshed theme list, nothing changed

Removing entry from core_theme table helped - my theme appeared on the list along with updated parent theme.

Is it the only way to have custom theme updated in core_theme? @Vinai do you observe similar behavior with your parent theme in themes.xml fix applied?

@Vinai
Copy link
Contributor

Vinai commented Jan 5, 2015

Hi wojtekn, the PR does not change the behavior you describe. I also manually removed the record from the core_theme table when I changed any value copied there.

@verklov verklov added CS and removed CS labels Jan 5, 2015
@vpelipenko vpelipenko self-assigned this Jan 9, 2015
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-32342

@Crustymd, we can't reproduce now the issue with processing themes when empty directory exists. Both lists in Content -> Design -> Themes and Store - > Configuration -> Design -> Design Theme are updated. Could your check it again on the latest code?

@wojtekn, @Vinai, you are right here that there is only manual way to update custom theme in core_theme table. This behavior will be reviewed during next planned work around theme management.

@vpelipenko
Copy link
Contributor

There are no updates from participants. Closed.

@wojtekn
Copy link
Contributor

wojtekn commented Feb 12, 2015

@vpelipenko did you make any decision around this? Maybe getting rid of core_theme table completely will do the trick?

magento-team pushed a commit that referenced this issue Apr 11, 2017
[SOUTH] MAGETWO-65075: Bump composer json version in private 2.1 branche to 2…
magento-engcom-team added a commit that referenced this issue Sep 7, 2019
…867

 - Merge Pull Request magento/graphql-ce#867 from magento/graphql-ce:GraphQL-810-testAddNonExistentConfigurableProduct
 - Merged commits:
   1. 25e1590
   2. bc832bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants