Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size for Product Watermarks [Magento 2.1.0] #5270

Closed
RG-1 opened this issue Jun 26, 2016 · 6 comments
Closed

Image size for Product Watermarks [Magento 2.1.0] #5270

RG-1 opened this issue Jun 26, 2016 · 6 comments
Assignees
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@RG-1
Copy link

RG-1 commented Jun 26, 2016

Steps to reproduce

  1. Magento 2.1.0
  2. Go to Content > Design: Configuration
  3. Edit any store view
  4. Go to "Product Image Watermarks" tab
  5. Try to enter "Image Size" (e.g. 200x300)

Expected result

  1. Field allows to enter digits and "x" as in the example.

Actual result

  1. Field allows to enter only digits.

watermark

@antboiko
Copy link

Hi @RG-1 , thanks for reporting. We've created internal ticket MAGETWO-54779 to fix this issue.

Best,
Anton.

@antboiko antboiko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Jun 27, 2016
@vkorotun vkorotun removed the CS label Aug 4, 2016
mmansoor-magento pushed a commit that referenced this issue Aug 26, 2016
…#5270

- adding custom validation for AAAxBBB type of inputs in validation rules with translation
mmansoor-magento pushed a commit that referenced this issue Aug 26, 2016
…#5270

- modifying js file for simplicity as per code review
mmansoor-magento pushed a commit that referenced this issue Aug 26, 2016
…#5270

- modifying js file for simplicity as per code review
mmansoor-magento pushed a commit that referenced this issue Aug 26, 2016
@gabriel-sf
Copy link

Hi guys,
is there any update or patch we can apply to fix this on M2.1?
Thanks,
Gab

@branouk
Copy link

branouk commented Sep 26, 2016

Hi guys,

as this is still not fixed in M2.1.1 there is a temporary solution how to enter the correct "Image Size" in the full format (e.g. 200x300)

  1. Go to your database with either phpmyadmin
    or cli -> "mysql -u database_user -p database_name"

  2. look for "core_config_data" table

and find the following PATH:

design/watermark/image_size
design/watermark/small_image_size
design/watermark/swatch_image_size
design/watermark/thumbnail_size

  1. set the VALUE manualy e.g. -> 200x300

@antboiko
Copy link

Hi @RG-1 @gabriel-sf. Please let me inform you this issue was fixed and delivered to the develop branch. The fix was also ported to 2.1 and will be available in one of nearest patches.

I'm closing this ticket. Please feel free to reopen if the issue is still reproducible for you on the develop branch.

Best,
Anton.

@gabriel-sf
Copy link

Hi @antboiko would you be able to specify how we can implement the patch to fix this issue?

okorshenko pushed a commit that referenced this issue Dec 14, 2016
…'t be set #5270

- applying changes from MAGETWO-54779 to 2.1
okorshenko pushed a commit that referenced this issue Dec 14, 2016
…'t be set #5270

- applying changes from MAGETWO-54779 to 2.1
okorshenko pushed a commit that referenced this issue Dec 14, 2016
…'t be set #5270

- correcting caps 200X300 to 200x300 for consistency
okorshenko pushed a commit that referenced this issue Dec 14, 2016
…'t be set #5270

- modifying regex to support both 200X300 to 200x300
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Fixed issue:
 - MAGETWO-56972: CLONE - [GitHub] Image size for Product Watermarks can't be set #5270
@elenleonova
Copy link

The issue has been delivered to 2.1.3

magento-engcom-team pushed a commit that referenced this issue Feb 6, 2020
[architecture] ECP-261: Offload Catalog Image Resizing from Magento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

7 participants