Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vat Validation URL for EU Vat numbers changed. (Vies Service) #27874

Closed
WIKAWebmaster opened this issue Apr 16, 2020 · 16 comments · Fixed by #27886
Closed

Vat Validation URL for EU Vat numbers changed. (Vies Service) #27874

WIKAWebmaster opened this issue Apr 16, 2020 · 16 comments · Fixed by #27886
Assignees
Labels
Component: Admin Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@WIKAWebmaster
Copy link

WIKAWebmaster commented Apr 16, 2020

An Vat Validation is not possible anymore because in the file:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/Model/Vat.php

On line 47 the is the following code available
const VAT_VALIDATION_WSDL_URL = 'http://ec.europa.eu/taxation_customs/vies/services/checkVatService?wsdl';

This url is not working anymore and should be changed to the new one to get it working again:
[http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl]

New Code
' const VAT_VALIDATION_WSDL_URL = 'http://ec.europa.eu/taxation_customs/vies/checkVatService.wsdl';

Preconditions (*)

Steps to reproduce (*)

Expected result (*)

[Screenshots, logs or description]

Actual result (*)

[Screenshots, logs or description]
@m2-assistant
Copy link

m2-assistant bot commented Apr 16, 2020

Hi @WIKAWebmaster. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@WIKAWebmaster do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Apr 16, 2020
@shikhamis11 shikhamis11 self-assigned this Apr 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2020

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@shikhamis11
Copy link
Member

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @shikhamis11, here is your Magento instance.
Admin access: https://i-27874-2-4-develop.instances.magento-community.engineering/admin_49d6
Login: facdbe41 Password: ef8c306dbeb5
Instance will be terminated in up to 3 hours.

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Apr 17, 2020
@shikhamis11 shikhamis11 added good first issue Component: Admin Component: Customer Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Apr 17, 2020
@ghost ghost unassigned shikhamis11 Apr 17, 2020
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @shikhamis11
Thank you for verifying the issue. Based on the provided information internal tickets MC-33515 were created

Issue Available: @shikhamis11, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 17, 2020
@shikhamis11 shikhamis11 self-assigned this Apr 17, 2020
@m2-assistant
Copy link

m2-assistant bot commented Apr 17, 2020

Hi @shikhamis11. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. If the issue is not relevant or is not reproducible any more, feel free to close it.


magento-engcom-team added a commit that referenced this issue Apr 25, 2020
…ed. #27886

 - Merge Pull Request #27886 from shikhamis11/magento2:2.4-devapril1
 - Merged commits:
   1. faaec18
   2. 49dc77b
magento-engcom-team added a commit that referenced this issue Apr 25, 2020
…op daily delivery

Accepted Community Pull Requests:
 - #27886: Fixed #27874 Vat Validation URL for EU Vat numbers changed. (by @shikhamis11)
 - #27093: #27089 Fix issue with returning non-available default limit (by @lbajsarowicz)
 - #27926: Fixes incorrectly nested html in the product items list template. (by @hostep)
 - #27740: Redirecting users to sales order history page (by @ajithkumar-maragathavel)
 - #27892: Fixes unstable email integration tests (by @hostep)
 - #27578: Fix Magento Integrity Dependency test in case to be used not in scope of app/code isntallation. (by @swnsma)
 - #27323: MFTF: Add `<magentoCron` instruction - CatalogImportExport / CatalogInventory / CatalogRule (by @lbajsarowicz)
 - #27887: Fix Arabic and Hebrew in invoices (by @ihor-sviziev)
 - #27966: Correct used in sections image pattern, minor fixes (by @Nazar65)


Fixed GitHub Issues:
 - #27089: BUG: `getDefaultLimitPerPageValue` returns value that is not available (reported by @lbajsarowicz) has been fixed in #27093 by @lbajsarowicz in 2.4-develop branch
   Related commits:
     1. 17236cc
     2. 381ab64
     3. 778fbfb
     4. d3962f2
     5. aec01d8
@magento-engcom-team magento-engcom-team added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label May 1, 2020
@magento-engcom-team
Copy link
Contributor

Hi @WIKAWebmaster. Thank you for your report.
The issue has been fixed in #27886 by @shikhamis11 in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.0 release.

@grossmann
Copy link

@magento-engcom-team
Question: Is this going to be backported to Magento 2.3.x or do I have to upgrade to 2.4.0 when it is released? I could not find any documentation about how backports are handled in Magento 2.
Thanks for your reply.

@hostep
Copy link
Contributor

hostep commented May 28, 2020

@grossmann: the @magento-engcom-team user is just a bot, it never replies when you ask it something 🙂
If you need a fix, you'd best create a patch yourself and apply it to your shop somehow, that's usually the fastest approach.

@slavvka: can you answer the question above if this fix will be backported to 2.3.x? (maybe the bot can somehow automate its answers when a fix is being backported, that could be really helpful for informing the people interested)

@grossmann
Copy link

@hostep Thanks for the hint with the bot ;-).
Sure, I already fixed it on my local 2.3.4-p2 installation. But if I do an composer update in the future, say to 2.3.x then the fix gets lost as it is not back ported.
A release for 2.4.0 is not yet available.

@chernenm-zz
Copy link

chernenm-zz commented Jun 1, 2020

Hello @hostep,

This issue has been backported into 2.3.x and will be released in 2.3.6.

Best regards,
Misha Chernenko.

@grossmann
Copy link

@chernenm Your link to the pull request gives a 404 error. Can you show me to the correct url?

@chernenm-zz
Copy link

Hello @grossmann,

I am sorry, it is not merged yet, it will be released in 2.3.6.

@slavvka
Copy link
Member

slavvka commented Jun 2, 2020

The link above is from internal repos.

@hostep
Copy link
Contributor

hostep commented Jun 4, 2020

Thanks @chernenm!

Would Magento consider opening up a 2.3.6-preview branch for upcoming new versions to the community. Since that would make things a lot clearer and we can search that branch to see if things are being backported yes or no?
A couple of years ago, these preview branches were available, but for some reason they got removed?

@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Component: Customer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch good first issue Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants