Magento\Customer\Model\Account\Redirect::setRedirectCookie() not properly working

[nikoskip]

Preconditions (*)

1. Magento 2.3.2

Steps to reproduce (*)

Call method Magento\Customer\Model\Account\Redirect::setRedirectCookie()

$this->accountRedirect->setRedirectCookie($this->urlBuilder->getUrl('checkout'));

Expected result (*)

Cookie login_redirect created

Actual result (*)

The cookie is sent to the browser, but not properly. All the cookie params are missing.

Additional information

I checked the code and the problem is that the method setPublicCookie needs to include a PublicCookieMetadata instance as third param.

<?php
// vendor/magento/module-customer/Model/Account/Redirect.php:280
/**
     * Save redirect route to cookie for case of successful login/registration
     *
     * @param string $route
     * @return void
     */
    public function setRedirectCookie($route)
    {
        $this->getCookieManager()->setPublicCookie(self::LOGIN_REDIRECT_URL, $route);
    }

Indeed maybe setPublicCookie should require $metadata as mandatory. Why someone would need to create a cookie without params?

[m2-assistant]

Hi @nikoskip. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@nikoskip do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[ralphgarrison]

@magento give me test instance

…

On Wed, Sep 11, 2019, 2:42 AM m2-assistant[bot] ***@***.***> wrote: Hi @engcom-Charlie <https://github.com/engcom-Charlie>. Thank you for working on this issue. In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇 - 1. Verify that issue has all the required information. (*Preconditions*, *Steps to reproduce*, *Expected result*, *Actual result*). DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears. - 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself. - 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to. - 4. Verify that the issue is reproducible on 2.3-develop branch Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure. - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x. - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and *stop verification process here*! - 5. Add label Issue: Confirmed once verification is complete. - 6. Make sure that automatic system confirms that report has been added to the backlog. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#24547?email_source=notifications&email_token=AL6CVBC4DMOKISOYFC5TLXLQJCHM5A5CNFSM4IVOWC22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6NOGRQ#issuecomment-530244422>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AL6CVBHRI6TPSVAEIUZ2DSTQJCHM5ANCNFSM4IVOWC2Q> .

[magento-engcom-team]

✅ Confirmed by @engcom-Charlie
Thank you for verifying the issue. Based on the provided information internal tickets MC-20107 were created

Issue Available: @engcom-Charlie, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[nikoskip]

BTW, the clearRedirectCookie is not working either. You also need to configure the cookie params to properly delete it.

I had to override this methods to get this to working. Here is my code if someone needs it, hope it helps!

<?php
    /**
     * @param string $route
     * @return void
     */
    public function setRedirectCookie($route)
    {
        $metadata = $this->cookieMetadataFactory->createPublicCookieMetadata();
        $metadata->setPath($this->sessionConfig->getCookiePath());
        $metadata->setDomain($this->sessionConfig->getCookieDomain());
        $metadata->setSecure($this->sessionConfig->getCookieSecure());
        $metadata->setHttpOnly($this->sessionConfig->getCookieHttpOnly());
        $metadata->setDuration($this->sessionConfig->getCookieLifetime());

        $this->getCookieManager()->setPublicCookie(self::LOGIN_REDIRECT_URL, $route, $metadata);
    }

    /**
     * @throws \Magento\Framework\Exception\InputException
     * @throws \Magento\Framework\Stdlib\Cookie\FailureToSendException
     */
    public function clearRedirectCookie()
    {
        $metadata = $this->cookieMetadataFactory->createPublicCookieMetadata();
        $metadata->setPath($this->sessionConfig->getCookiePath());
        $metadata->setDomain($this->sessionConfig->getCookieDomain());

        $this->getCookieManager()->deleteCookie(self::LOGIN_REDIRECT_URL, $metadata);
    }

[m2-assistant]

Hi @sashas777. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

• 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 2. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 3. If the issue is not relevant or is not reproducible any more, feel free to close it.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[magento-engcom-team]

Hi @nikoskip. Thank you for your report.
The issue has been fixed in #24612 by @sashas777 in 2.4-develop branch
Related commit(s):

• a15f33557d72d4ab05a99e9583fbfc0e2daa2ba2
• 664056fc0e4fedc5c10aac2d14537b285dbefffd
• 5188efdbcfe31e02147d2fc6846ffd5d40e4d0ca
• 3cf8f224a3f850aa0838b700ba390eb25fd1f704
• 75970034babbf4525a2ccf5bf4ecfbe4d55fa897
• 94138920f8c54365bc29f72b63b3a2de9c04a0a0
• 9f2bbc2c0060ce884c186a627403c1296080fe2d
• bfa636f75b220e3a59cb168ccc79b6ccdb055e07
• 6446aed759f9ed44c1fecde4632e14f786b3117a
• 162ca604dae34980e972934bd4786756de52b0a1
• 16da7068cdcc6077ff9ea2f58a0b20f56932e310
• 2c24ef9a6c15d342bc7109e09d1b5169482b3917
• a514803313c20892020313c57fc50d336948d918
• bfeadd7e3971a278784155cfddefc80c7aeeb07d
• cd5ef3c32cfbcab0b080ab22e5c4a46f8f6b759c
• dc416a9bb545517384bff75c1bc1e181a1343af0
• 41ce59e5f53564e9e665660ccee618a390ca1de3
• f021f1ef0514a9588eb439f689dcde99cef7525d
• 511e16a3ce006cb31621cb9b87cd576f0304c62b

The fix will be available with the upcoming 2.4.0 release.