Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#search input is missing required attribute aria-expanded. #18337

Closed
BezV8 opened this issue Oct 2, 2018 · 18 comments
Closed

#search input is missing required attribute aria-expanded. #18337

BezV8 opened this issue Oct 2, 2018 · 18 comments
Assignees
@geet07
Labels
Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@BezV8
Copy link
Contributor

BezV8 commented Oct 2, 2018

Fix from issue #2681 seems to have regressed and a blank install of 2.2.6 is again showing errors on the W3C html validator for the #search element.

Preconditions

  1. Magento 2.2.6
  2. Magento Blank theme enabled.

Steps to reproduce

  1. Check homepage in W3C html validator.

Expected result

  1. After issue W3C error: Element input is missing required attribute aria-expanded. #2681 closed validation should be clean.

Actual result

  1. Validator is again showing error for #search.
@magento-engcom-team
Copy link
Contributor

Hi @BezV8. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me $VERSION instance

where $VERSION is version tags (starting from 2.2.0+) or develop branches (for example: 2.3-develop).
For more details, please, review the Magento Contributor Assistant documentation.

@BezV8 do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Oct 2, 2018
@BezV8
Copy link
Contributor Author

BezV8 commented Oct 2, 2018

@magento-engcom-team give me 2.2.6 instance

@magento-engcom-team
Copy link
Contributor

Hi @BezV8. Thank you for your request. I'm working on Magento 2.2.6 instance for you

@magento-engcom-team
Copy link
Contributor

Hi @BezV8, here is your Magento instance.
Admin access: https://i-18337-2-2-6.engcom.dev.magento.com/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@BezV8
Copy link
Contributor Author

BezV8 commented Oct 2, 2018

@magento-engcom-team Issue confirmed on test instance.

@BezV8
Copy link
Contributor Author

BezV8 commented Oct 2, 2018

Screenshot of validation error:
screenshot_2018-10-02 showing results for https i-18337-2-2-6 engcom dev magento com - nu html checker

@BezV8 BezV8 mentioned this issue Oct 2, 2018
Closed
@ghost ghost self-assigned this Nov 28, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 28, 2018 •
edited by ghost
Loading

Hi @engcom-backlog-andrii. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@ghost
Copy link

ghost commented Nov 28, 2018

@magento-engcom-team give me 2.2-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-andrii. Thank you for your request. I'm working on Magento 2.2-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @engcom-backlog-andrii, here is your Magento instance.
Admin access: https://i-18337-2-2-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

@ghost ghost added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Theme Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Nov 28, 2018
@magento-engcom-team
Copy link
Contributor

@engcom-backlog-andrii Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-96698, MAGETWO-96699 were created

@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 28, 2018
@ghost ghost removed their assignment Nov 28, 2018
@geet07 geet07 self-assigned this May 15, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 15, 2019

Hi @geet07. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

  • 1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 2. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 3. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 4. If the issue is not relevant or is not reproducible any more, feel free to close it.

@geet07
Copy link

geet07 commented May 17, 2019

@magento-engcom-team give me 2.3-develop

@geet07
Copy link

geet07 commented May 17, 2019

@magento-engcom-team give me 2.3-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @geet07. Thank you for your request. I'm working on Magento 2.3-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @geet07, here is your Magento instance.
Admin access: https://i-18337-2-3-develop.instances.magento-community.engineering/admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

geeta07 added a commit to geeta07/magento2 that referenced this issue May 19, 2019
@geeta07
Fixed issue magento#18337
eeae4b2
@geet07 geet07 mentioned this issue May 20, 2019
Merged
4 tasks
@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jun 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @BezV8. Thank you for your report.
The issue has been fixed in #22942 by @geet07 in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.3 release.

magento-engcom-team added a commit that referenced this issue Jun 19, 2019
@magento-engcom-team
ENGCOM-5135: Fixed issue #18337 #22942
c1d20be 
 - Merge Pull Request #22942 from geeta07/magento2:fix-18337
 - Merged commits:
   1. eeae4b2
   2. c3955b2
   3. bf4fbf0
   4. 81c722d
magento-engcom-team pushed a commit that referenced this issue Jun 19, 2019
@VladimirZaets
ENGCOM-5135: Fixed issue #18337 #22942
7bb085a
@amol2jcommerce amol2jcommerce mentioned this issue Jun 20, 2019
Merged
4 tasks
amol2jcommerce pushed a commit to amol2jcommerce/magento2 that referenced this issue Jun 20, 2019
@geeta07 @amol2jcommerce
Fixed issue magento#18337
83a9c9b
@magento-engcom-team magento-engcom-team added the Fixed in 2.2.x The issue has been fixed in 2.2 release line label Jun 26, 2019
@magento-engcom-team
Copy link
Contributor

Hi @BezV8. Thank you for your report.
The issue has been fixed in #23331 by @amol2jcommerce in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.10 release.

magento-engcom-team added a commit that referenced this issue Jun 26, 2019
@magento-engcom-team
ENGCOM-5354: [Backport] Fixed issue #18337 #23331
5cbe295 
 - Merge Pull Request #23331 from amol2jcommerce/magento2:2.2-develop-PR-port-22942
 - Merged commits:
   1. 83a9c9b
   2. 39e7c2c
   3. 3d989c6
magento-engcom-team pushed a commit that referenced this issue Jun 26, 2019
@sidolov
ENGCOM-5354: [Backport] Fixed issue #18337 #23331
b60f904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geet07 geet07

Labels
Component: Theme Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line good first issue Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmanners @geet07 @magento-engcom-team @BezV8