Skip to content

Commit

Permalink
Remove backwards breaking ChangelogCounterInterface
Browse files Browse the repository at this point in the history
  • Loading branch information
convenient committed Dec 4, 2017
1 parent 700fe22 commit ca50c9d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 39 deletions.
18 changes: 1 addition & 17 deletions lib/internal/Magento/Framework/Mview/View/Changelog.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
use Magento\Framework\App\ResourceConnection;
use Magento\Framework\Phrase;

class Changelog implements ChangelogInterface, ChangelogCounterInterface
class Changelog implements ChangelogInterface
{
/**
* Suffix for changelog table
Expand Down Expand Up @@ -169,22 +169,6 @@ public function getList($fromVersionId, $toVersionId)
return $this->connection->fetchCol($select);
}

/**
* Retrieve the count of entity ids in the range [$fromVersionId..$toVersionId]
*
* @param int $fromVersionId
* @param int $toVersionId
* @return int[]
* @throws ChangelogTableNotExistsException
*/
public function getListSize($fromVersionId, $toVersionId)
{
$countSelect = $this->getListSelect($fromVersionId, $toVersionId);
$countSelect->reset(\Magento\Framework\DB\Select::COLUMNS);
$countSelect->columns(new \Zend_Db_Expr(("COUNT(DISTINCT " . $this->getColumnName() . ")")));
return $this->connection->fetchOne($countSelect);
}

/**
* Get maximum version_id from changelog
* @return int
Expand Down

This file was deleted.

0 comments on commit ca50c9d

Please sign in to comment.