Skip to content

Commit

Permalink
Merge pull request #2863 from magento-earl-grey/MAGETWO-67627
Browse files Browse the repository at this point in the history
[earl] MAGETWO-67627: CMS Page does not save when same url key with hierarchy for Multi-store
  • Loading branch information
cpartica authored Jul 20, 2018
2 parents af2ec60 + c5e95c6 commit 08d13a1
Show file tree
Hide file tree
Showing 10 changed files with 106 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
<actionGroup name="CreateNewPageWithAllValues">
<arguments>
<argument name="PageTitle" type="string"/>
<argument name="ContentHeading" type="string"/>
<argument name="URLKey" type="string"/>
<argument name="selectStoreViewOpt" type="string"/>
<argument name="selectHierarchyOpt" type="string"/>
</arguments>
<amOnPage url="{{CmsNewPagePage.url}}" stepKey="amOnCMSNewPage"/>
<waitForPageLoad stepKey="waitForPageLoad1"/>
<fillField selector="{{CmsNewPagePageBasicFieldsSection.pageTitle}}" userInput="{{PageTitle}}" stepKey="fillFieldTitle"/>
<click selector="{{CmsNewPagePageContentSection.header}}" stepKey="clickExpandContent"/>
<fillField selector="{{CmsNewPagePageContentSection.contentHeading}}" userInput="{{ContentHeading}}" stepKey="fillFieldContentHeading"/>
<click selector="{{CmsNewPagePageSeoSection.header}}" stepKey="clickExpandSearchEngineOptimization"/>
<fillField selector="{{CmsNewPagePageSeoSection.urlKey}}" userInput="{{URLKey}}" stepKey="fillFieldURLKey"/>
<click selector="{{CmsNewPagePiwSection.header}}" stepKey="clickPageInWebsites"/>
<waitForElementVisible selector="{{CmsNewPagePiwSection.selectStoreView(selectStoreViewOpt)}}" stepKey="waitForStoreGridReload"/>
<clickWithLeftButton selector="{{CmsNewPagePiwSection.selectStoreView(selectStoreViewOpt)}}" stepKey="clickStoreView2"/>
<click selector="{{CmsNewPageHierarchySection.header}}" stepKey="clickHierarchy"/>
<click selector="{{CmsNewPageHierarchySection.selectHierarchy(selectHierarchyOpt)}}" stepKey="clickPageCheckBoxes"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->
<actionGroups xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Test/etc/actionGroupSchema.xsd">
<actionGroup name="DeletePageByUrlKeyActionGroup">
<arguments>
<argument name="UrlKey" type="string"/>
</arguments>
<amOnPage url="{{CmsPagesPage.url}}" stepKey="amOnCMSNewPage"/>
<waitForPageLoad stepKey="waitForPageLoad1"/>
<click selector="{{CmsPagesPageActionsSection.select(UrlKey)}}" stepKey="clickSelect"/>
<click selector="{{CmsPagesPageActionsSection.delete(UrlKey)}}" stepKey="clickDelete"/>
<waitForElementVisible selector="{{CmsPagesPageActionsSection.deleteConfirm}}" stepKey="waitForOkButtonToBeVisible"/>
<click selector="{{CmsPagesPageActionsSection.deleteConfirm}}" stepKey="clickOkButton"/>
<waitForPageLoad stepKey="waitForPageLoad3"/>
<see userInput="The page has been deleted." stepKey="seeSuccessMessage"/>
</actionGroup>
</actionGroups>
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
<section name="CmsNewPageHierarchySection">
<element name="header" type="button" selector="div[data-index=hierarchy]" timeout="30"/>
<element name="selectHierarchy" type="button" selector="//a/span[contains(text(),'{{var1}}')]" parameterized="true" timeout="30"/>
</section>
</sections>



15 changes: 15 additions & 0 deletions app/code/Magento/Cms/Test/Mftf/Section/CmsNewPagePiwSection.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
*/
-->

<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
<section name="CmsNewPagePiwSection">
<element name="header" type="button" selector="div[data-index=websites]" timeout="30"/>
<element name="selectStoreView" type="select" selector="//option[contains(text(),'{{var1}}')]" parameterized="true"/>
</section>
</sections>
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,7 @@
<element name="firstItemEditButton" type="button" selector=".data-grid .action-select-wrap .action-menu-item[data-action~='item-edit']"/>
<element name="activeFilter" type="button" selector="(//div[contains(@class, 'admin__data-grid-filters-current') and contains(@class, '_show')])[1]"/>
<element name="savePageSuccessMessage" type="text" selector=".message-success"/>
<element name="delete" type="button" selector="//div[text()='{{var1}}']/parent::td//following-sibling::td[@class='data-grid-actions-cell']//a[text()='Delete']" parameterized="true"/>
<element name="deleteConfirm" type="button" selector=".action-primary.action-accept" timeout="60"/>
</section>
</sections>
10 changes: 10 additions & 0 deletions app/code/Magento/Store/Test/Mftf/Data/StoreData.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,14 @@
<data key="store_type">group</data>
<requiredEntity type="storeGroup">customStoreGroup</requiredEntity>
</entity>
<entity name="staticStore" type="store">
<!--data key="group_id">customStoreGroup.id</data-->
<data key="name" >Second Store View</data>
<data key="code" >store123</data>
<data key="is_active">1</data>
<data key="store_id">null</data>
<data key="store_action">add</data>
<data key="store_type">group</data>
<requiredEntity type="storeGroup">customStoreGroup</requiredEntity>
</entity>
</entities>
11 changes: 4 additions & 7 deletions app/code/Magento/Store/Test/Mftf/Data/StoreGroupData.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@
<data key="store_action">add</data>
<data key="store_type">group</data>
</entity>
<entity name="CustomStoreGroupCustomWebsite" type="group">
<data key="group_id">null</data>
<data key="name" unique="suffix">Store Group Custom Website</data>
<data key="code" unique="suffix">store_group_custom_website</data>
<entity name="staticStoreGroup" type="group">
<data key="name">NewStore</data>
<data key="code">Base12</data>
<data key="root_category_id">2</data>
<data key="store_action">add</data>
<data key="store_type">group</data>
<requiredEntity type="website">customWebsite</requiredEntity>
<data key="website_id">1</data>
</entity>
</entities>
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@
<element name="backButton" type="button" selector="#back" timeout="30"/>
<element name="delete" type="button" selector="#delete" timeout="30"/>
<element name="resetButton" type="button" selector="#reset" timeout="30"/>
<element name="saveButton" type="button" selector="#save" timeout="30"/>
<element name="saveButton" type="button" selector="#save" timeout="60"/>
</section>
</sections>
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
-->
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
<section name="AdminNewWebsiteActionsSection">
<element name="saveWebsite" type="button" selector="#save" timeout="30"/>
<element name="saveWebsite" type="button" selector="#save" timeout="60"/>
</section>
</sections>
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
-->
<sections xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../dev/tests/acceptance/vendor/magento/magento2-functional-testing-framework/src/Magento/FunctionalTestingFramework/Page/etc/SectionObject.xsd">
<section name="AdminStoreGroupActionsSection">
<element name="saveButton" type="button" selector="#save" timeout="30" />
<element name="saveButton" type="button" selector="#save" timeout="60" />
</section>
</sections>

0 comments on commit 08d13a1

Please sign in to comment.