Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support - fix code related to changes in CURL #868

Conversation

karyna-t
Copy link
Contributor

@karyna-t karyna-t commented Aug 18, 2021

Description

Fixed fragments of code related to changes in Curl in PHP 8 (where it was necessary) according to the document:
https://www.php.net/manual/en/migration80.incompatible.php

Fixed Issues (if relevant)

  1. [MFTF] Investigate and fix code related to changes in CURL magento2#33781: [MFTF] Investigate and fix code related to changes in CURL

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@magento-engcom-team magento-engcom-team added Partner: Atwix partners-contribution Pull Request is created by Magento Partner labels Aug 18, 2021
@KevinBKozan KevinBKozan self-requested a review August 18, 2021 15:35
@KevinBKozan
Copy link
Contributor

@magento-engcom-team
Copy link

@KevinBKozan the pull request successfully imported.

@magento-devops-reposync-svc magento-devops-reposync-svc merged commit c2d5d6b into magento:develop Aug 23, 2021
@karyna-t karyna-t deleted the improvement/mftf-33781-fix-code-related-changes-in-curl branch September 30, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Partner: Atwix partners-contribution Pull Request is created by Magento Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants